这是indexloc提供的服务，不要输入任何密码
Skip to content

perf: use initializer instead of late initialization and polymorph getters #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

perf: use initializer instead of late initialization and polymorph getters #399

wants to merge 1 commit into from

Conversation

Zekfad
Copy link

@Zekfad Zekfad commented Jul 16, 2025 •
edited by sourcery-ai bot
Loading

  • Performance improvement: use initializer instead of late initialization and polymorph getters

Summary by Sourcery

Use constructor initializers and final fields to remove late initialization and polymorphic getters for improved performance.

Enhancements:

  • Replace private late _time and its getter in TalkerData with a final time initialized in the constructor initializer list
  • Move TalkerData key field to a final property and initialize it via the constructor initializer
  • Simplify TalkerException and TalkerError constructors by passing key and logLevel directly to the TalkerData super constructor and removing custom getters and late fields

@Zekfad
perf: use initializer instead of late initialization and polymorph ge…
a71e227 
…tters

this will remove late initialization checks from runtime and unnecessary
getter overloads, which will also make classes more friendly to extension
@sourcery-ai Sourcery AI
Copy link
Contributor

sourcery-ai bot commented Jul 16, 2025 •
edited
Loading

Reviewer's Guide

Replaces late-backed fields and overridden getters with constructor initializer lists and final fields to reduce indirection and improve performance.

Class diagram for updated TalkerData, TalkerException, and TalkerError

classDiagram
  class TalkerData {
    <<abstract>>
    String? message
    LogLevel? logLevel
    Exception? exception
    Error? error
    StackTrace? stackTrace
    String? title
    DateTime time
    AnsiPen? pen
    String? key
  }

  class TalkerException {
    Exception exception
    String? message
    String? key
    String? title
    LogLevel? logLevel
    --
    +generateTextMessage()
  }

  class TalkerError {
    Error error
    String? message
    String? key
    String? title
    LogLevel? logLevel
    --
    +generateTextMessage()
  }

  TalkerException --|> TalkerData
  TalkerError --|> TalkerData
Loading

File-Level Changes

Change Details Files
Refactor TalkerData time initialization
  • Use constructor initializer list to set time instead of late-backed field
  • Remove late DateTime _time and time getter
  • Declare time as a final field
 packages/talker/lib/src/models/talker_data.dart
Reorder and finalize key and title fields in TalkerData
  • Move key declaration after pen and mark it final
  • Reposition title field near other metadata fields
 packages/talker/lib/src/models/talker_data.dart
Simplify TalkerException and TalkerError constructors
  • Replace constructor bodies with super initializer lists passing key and logLevel
  • Remove late-backed _key and _logLevel fields and their getters
 packages/talker/lib/src/models/talker_exception.dart
packages/talker/lib/src/models/talker_error.dart
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Jul 16, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Zekfad - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Zekfad Zekfad mentioned this pull request Jul 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Zekfad