blink.infra
| Legend: | Passed | Failed | Running | Exception |
Remove IsTabGroupSyncEnabled
This CL removes the helper function (that returned true unconditionally)
and all the dead codepaths.
Bug: 433919353
Change-Id: I9bc6813898dfb5f7a7021c278b0a71746bcdde9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6778650
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Louis Romero <lpromero@google.com>
Cr-Commit-Position: refs/heads/main@{#1492158}
Remove tab grid related APIs from RecentTabs{Coordinator|Mediator}
Recent Tabs is no longer shown from Tab Grid, so remove all arguments
and codepaths related to Tab Grid in Recent Tabs.
Bug: 433919353
Change-Id: Ie59b0055a24320a576c842952bb61303c0645614
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6783849
Reviewed-by: Ginny Huang <ginnyhuang@chromium.org>
Commit-Queue: Louis Romero <lpromero@google.com>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1492157}
Roll Perfetto Trace Processor Linux from ab99948900d2 to fbf4761bef94
https://android.googlesource.com/platform/external/perfetto.git/+log/ab99948900d2..fbf4761bef94
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC chrometto-team@google.com,perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: perfetto-bugs@google.com
Change-Id: I9268aecb30c2cc5a936aa635054f53bc76daa783
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6788791
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1492156}
[soft navs] Refactor AddPaintedArea to take PaintTimingRecord
Follow-up to crrev.com/c/6781530. Refactor AddPaintedArea() to take
PaintTimingRecord* instead of specializations for TextRecord* and
ImageRecord*, since we can now share more code.
Bug: 434130450
Change-Id: Id67d074b1f71a602145cc6d624c766ef0e6be5c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6782230
Commit-Queue: Scott Haseley <shaseley@chromium.org>
Reviewed-by: Michal Mocny <mmocny@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1492155}
Reland "pgo: Fix GN inputs to be more robust"
Changed:
- Rebased on fix that uses atime instead of mtime.
Previously GN did not include the actual PGO profile data file
(.profdata) as a build input. This meant that if the profile data
changed without its corresponding .pgo.txt file also changing, a rebuild
would not be triggered. This CL fixes this by adding the pgo_data_path
to the list of inputs. This can happen when pgo_data_path or when
pgo_override_filename is set in args.gn.
Additionally, this CL moves the decision to use a different PGO profile
by default for android arm64 to python instead of GN.
Bug: 364987714, 372694052, 372693875
Change-Id: I1b60e762f3211a658600d793283b9e7a051e4190
Fixed: 372693875
Cq-Include-Trybots: luci.chrome.try:mac-rel-ready
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6778918
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1492154}
[omnibox][ml] Enable ML URL Score Caching by default on iOS.
Based on the offline chat about this topic, this CL enables the
`kMlUrlScoreCaching` flag by default on iOS (which will bring about ML
scoring performance benefits).
For context, this flag has been experimented with extensively on
Desktop and is not anticipated to cause any crashes. However, we should
be able to easily revert this CL should any unforeseen issues arise due
to enabling this flag by default.
Bug: 40062540
Change-Id: I756441a32f21400c5b8e7c272cbcb5f8e64fe80b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6784160
Commit-Queue: Khalid Peer <khalidpeer@chromium.org>
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1492153}
pgo: Use atime to avoid changing profile mtime
The script was updating the modification time (mtime) of PGO profiles on
every build. This can interfere with siso, which relies on mtime to
track file changes.
This CL updates the script to modify the access time (atime) instead.
Profile cleanup now also uses atime, preserving the original mtime for
build tooling while still allowing unused profiles to be cleaned up.
R=jeffyoon@google.com
Bug: 434010397, 364987714, 433993087
Fixed: 434010397
Change-Id: I7db7729c4ccb14cb53cb6a41bbe707c16f9b2245
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6785187
Commit-Queue: Peter Wen <wnwen@chromium.org>
Commit-Queue: Jeff Yoon <jeffyoon@google.com>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Jeff Yoon <jeffyoon@google.com>
Cr-Commit-Position: refs/heads/main@{#1492152}
.gitignore: Do not ignore non-root GEMINI.md
These often appear in gemini extensions.
Change-Id: I4367ef45cb479b59e2eccbcd9d8871a64cd365b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6787630
Reviewed-by: Erik Staab <estaab@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1492151}
[CAA-Crowdstrike] Add agent signals to report request
Adds the collection of detected agent signals to the chrome profile
signals report request.
Bug: 430135330
Change-Id: Ibe870f3d306411dc5f5de6d172819b06e1b06c1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6785407
Commit-Queue: Hamda Mare <hmare@google.com>
Reviewed-by: Sébastien Lalancette <seblalancette@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1492150}
Roll ANGLE from f4d16e6432b1 to e4007fff3335 (1 revision)
https://chromium.googlesource.com/angle/angle.git/+log/f4d16e6432b1..e4007fff3335
2025-07-25 geofflang@chromium.org GL: Remove ARB_base_instance check for EXT_base_instance support
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: chromium:427956856
Tbr: syoussefi@google.com
Change-Id: I8dc7051468e2018e1322ba595ad05a8b35044cba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6787577
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1492149}
Reland "Close the split-tab-view drop target when dragging ends prematurely"
This is a reland of commit fd00a61bbfca5d7616add6dda73dec0de609e32a
Updates BrowserView to check that DnD is enabled for SxS tabs, which
may not be the case for Wayland.
Original change's description:
> Close the split-tab-view drop target when dragging ends prematurely
>
> This CL addresses a bug where ending a drag while the drop target is
> animating-in (but before the cursor is over the drop target) causes the
> drop target view to be stuck visible. The reason for this was that the
> `MultiContentsViewDropTargetController` does not close the target drop
> view for "drag exit" events, and the drop target view isn't handling
> drags yet.
>
> This is fixed by plumbing drag-end events, similar to how drag-exit and
> drag-update events are plumbed.
>
> Change-Id: Icd5c070ec8fafaff71af0c5edd62acc2b6f0cbfd
> Bug: 433720670
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6777771
> Reviewed-by: Alison Gale <agale@chromium.org>
> Commit-Queue: Kaan Alsan <alsan@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1491573}
Bug: 433720670
Change-Id: I8c22bafabd5ea6a87311d8b71e81a592414067d7
CQ-Include-Trybots: luci.chromium.try:linux-wayland-weston-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6788173
Reviewed-by: Alison Gale <agale@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Kaan Alsan <alsan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1492148}
Sync feature protos.
This CL was generated by a Copybara workflow. See the attached bug for more details.
BbcpOrigin-RevId: 786856670
Change-Id: I20161a8a246232e8b0c49e454f44691e3c0335bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6780024
Commit-Queue: Max Curran <curranmax@chromium.org>
Reviewed-by: Sreeja Kamishetty <sreejakshetty@chromium.org>
Auto-Submit: Copybara Service <copybara-worker-blackhole@google.com>
Reviewed-by: Max Curran <curranmax@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1492147}
Roll DevTools Frontend from 88aea57d6f7f to 5a3fec023392 (1 revision)
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/88aea57d6f7f..5a3fec023392
2025-07-25 alinavarkki@google.com Change a suggested question for the Modern HTPP Insight
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC liviurau@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:425275238
Change-Id: I85f667d8510c941e7a4df8f97b610200fda033a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6786513
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1492146}
Auto-format //ui GN files
Run "gn format" and automatically shorten target references, now that GN
knows how to do this. Note that ui/accessibility/extensions/BUILD.gn
does not have any target names to shorten, but could use better
formatting.
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome
Bug: 40760278
Change-Id: Ieaccbc6107ec97008d3c14121178753919c937d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6787271
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Auto-Submit: Lei Zhang <thestig@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1492145}
Auto-format GN files in various directories
Run "gn format" and automatically shorten target references, now that GN
knows how to do this.
Bug: 40760278
Change-Id: Iec40f7d091ac0f2573b56e366a0d9b5e0302151d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6786388
Auto-Submit: Lei Zhang <thestig@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Owners-Override: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1492144}
Check subject before adding it to the share extension item
Fixed: 433824534
Change-Id: Id16f4823ea6683cfbe591d071ab20f4e19c75ddb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6788474
Auto-Submit: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1492143}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1753433921-af4dd72aedbead37edc3e1c5f67fa65da9c3239a-130ca0cec3aa2658e8138157d15c30803b4c717f.profdata to chrome-win32-main-1753444792-79f6b8f6e79badffa6585c8fa048b0f5b7388715-b8adc83fcaaadddbd281c738a01518bb24136997.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I0517bb0f38e3fd9fca0ce978746963f6835fb2fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6788407
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1492142}
[iOS] cleanup flag kEnterpriseRealtimeEventReportingOnIOS.
Remove the flag, the realtime reporting on iOS was launched in M137.
Change-Id: I59d987ca09e371e2b4a772a4393b8edd3b26c6da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6783368
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Xu Li <mxlg@google.com>
Reviewed-by: Nancy Xiao <nancylanxiao@google.com>
Reviewed-by: Ernesto Izquierdo Clua <eic@google.com>
Cr-Commit-Position: refs/heads/main@{#1492141}
Disable password change when the feature disabled by enterprise policy
Fixed: 433462740
Change-Id: I16e6e3410d82b28e31e14813a61f625866c38f7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6787931
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com>
Cr-Commit-Position: refs/heads/main@{#1492140}
Update password change visibility in settings
This CL updates the visibility in setting. The password change entry
point will be visible only to users who interacted with the feature.
Bug: 392020509
Change-Id: I080146aff5fe09c3abbc79e3d3fae1f1881f9cf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6786053
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com>
Cr-Commit-Position: refs/heads/main@{#1492139}
Format chrome/browser/ui BUILD.gn dependency targets
Remove redundant :target_name suffixes from dependency declarations
where the target name matches the directory name, following GN
formatting conventions.
Bug: None
Change-Id: I80f30ae3cbe1392167927a18d8b21e85beede81c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6788617
Auto-Submit: Tiago Vignatti <tvignatti@igalia.com>
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Alexander Dunaev <adunaev@igalia.com>
Commit-Queue: Alexander Dunaev <adunaev@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1492138}
Replace direct `result.error` empty string checks with `is_ok()` helper
This takes a step toward being able to rename (and make private!) the
`error` field, by removing many direct references.
This CL was made by running:
rg -g "*test*.cc" -g "!*unittest.cc" "\.error\.empty\(\)" -l | \
xargs sed -i 's/\.error\.empty()/.is_ok()/g'
And then fixing up the false positives. I also ran variations of the
following to find some more cases, which I fixed up manually:
rg -g "*test*" -g "!*unittest.cc" "\.error,\s+\"\""
Bug: 431787497
Change-Id: I3648b963b36905bde49d6d96ce537dda881047ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6782885
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Auto-Submit: Chris Fredrickson <cfredric@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1492137}
Roll Perfetto Trace Processor Win from 197c2ac5ee9f to ab99948900d2
https://android.googlesource.com/platform/external/perfetto.git/+log/197c2ac5ee9f..ab99948900d2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium
Please CC chrometto-team@google.com,perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: perfetto-bugs@google.com
Change-Id: Idb196d9f9faac65b8a95470b9353f391a52c348e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6785912
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1492136}
Minor refactor to TabPersistentStore.
Bug: 433530529
Change-Id: If2a4e06b211b388de1c68db41fbc5594be62bf42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6785567
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Auto-Submit: Sky Malice <skym@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1492135}
Compare domains instead of urls when opening details
Fixed: 434132186
Change-Id: I2bb6d28f791ff979cd87691dc3ea4d7511f705ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6783101
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com>
Cr-Commit-Position: refs/heads/main@{#1492134}
Skip some PrivacySandboxSettings tests
These tests require 3rd party cookie blocking origin trial which isn't
supported on blink on iOS yet.
Change-Id: I2eea6549ce2882c3a401a7fed9f5d7d043f91198
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6777705
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Auto-Submit: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1492133}
Revert "[Sysroot] Preserve files need to pass basic compiler sanity check"
This reverts commit 5b3b9724ff543845f553687ea4334d504addfd57.
Reason for revert: No longer necessary now that [1] is fixed.
[1] https://crbug.com/396630697
Original change's description:
> [Sysroot] Preserve files need to pass basic compiler sanity check
>
> Preserve a few libc6 shared libraries so that devtools-frontend's C++
> Debugging Extension build can pass a basic test to see if the C++
> compiler works.
>
> Change-Id: I8e888ae1689aaf7d8562371e31c121516638d0c6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6263052
> Commit-Queue: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1422199}
Change-Id: I5ad3baf68affdbf7f592ef9dd450122f0e849e6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6785649
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1492132}
Add OS synchronization after `DefaultHandlersForFileExtensions` pref change
This change ensures that OS file handlers are kept in sync with the
`DefaultHandlersForFileExtensions` preference. It introduces
synchronization whenever this preference is modified, fixing an issue
where OS handlers were not automatically updated after mid-session
changes to the preference value.
Change-Id: I53391342490eb0ec36d6d9c5b323e40b3c292ff1
Bug: 411023280
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6782939
Reviewed-by: Andrew Rayskiy <greengrape@google.com>
Reviewed-by: Dibyajyoti Pal <dibyapal@chromium.org>
Commit-Queue: Magdalena Skarbińska <mskarbinska@google.com>
Cr-Commit-Position: refs/heads/main@{#1492131}
Fix build/install-build-deps.sh --no-prompt --android on cloudtops
Complained of needing --allow-downgrades, so I added --allow-downgrades.
Bug: 434155507
Change-Id: I8dc36dcda893c34af0138d246e87ac6ee6976a83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6788749
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1492130}
Make SceneUnderstandingManager delegate Plane and HitTest logic
Rather than have the SceneUnderstandingManager control all of the hit
test and plane code, creates a set of delegates that can also be
implemented by the subclasses in order to make the code a bit more
logical/easier to follow. This is partially in preparation for adding
plane_detection support and partially in preparation for implementing
a SceneUnderstanding system on top of XR_EXT_spatial_entities. This
change makes only the minimal changes necessary to the code to compile
with the split-dependdencies (e.g. cross-talk from the HitTestManager
to the PlaneManager where previously members existed in the same
class). Future changes will move the anchor manager in, clean up the
`FrameUpdate` logic, hide the SceneUnderstandingManager outside of the
OpenXrApiWrapper, and re-evaluate how extensions/features are exposed
and used in the SceneUnderstandingManager*Factory classes.
Bug: 394772465
Change-Id: Ifcfd7b5a60ba309ce103ed973b3f61c062f42deb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6778406
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1492129}
controlledframe: Convert URLPattern to match pattern in content scripts
Bug: 432827518
Change-Id: I8d364cce537018d34f378d72f4d4ac574748b4c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6785850
Auto-Submit: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Simon Hangl <simonha@google.com>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1492128}
[APC] Record model quality logs when the flow is halted by OTP detection
Bug: 432663638
Change-Id: I0a41a3d4cc5f31adc042d774a5cccfa01cb716f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6783407
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Fiorella Barrientos Villalta <fiorellab@google.com>
Reviewed-by: Viktor Semeniuk <vsemeniuk@google.com>
Cr-Commit-Position: refs/heads/main@{#1492127}
Roll Amd64 AFDO from 140.0.7313.0_pre1490386_rc-r1-merged to 140.0.7317.0_pre1491800_rc-r1-merged
This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file go/crostc-bug.
Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/afdo-chromium
Please CC c-compiler-chrome@google.com,mobiletc-prebuild@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium Main: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: mobiletc-prebuild@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I5fbf18b7213cfb06ba6c0791c49747ab287c0869
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6788849
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1492126}
Added `isMediaActive` and `isTabContentCaptured` to TabData.
These new properties correspond to tab indicators: media content is
playing and/or screen content is being captured.
This updates the states alongside basic tab changes that are already
tracked. A future change can update the state when audio and screen
capture change.
Change-Id: I551c7fff7f4a639ce631cd93bf9f3445ccab6d0a
Bug: b:425683537
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6778447
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Michael Crouse <mcrouse@chromium.org>
Reviewed-by: Dan Harrington <harringtond@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1492125}
Revert "Allow Loopback AEC on Mac only when Catap loopback is available"
This reverts commit f85d3f1898aad51e0f379bd577bc4e9b796430e1.
Reason for revert: Causing failures on the mac13-arm64-rel-tests
bot.
https://ci.chromium.org/ui/p/chromium/builders/ci/mac13-arm64-rel-tests/55389/overview
More details in: crbug.com/434199505
Bug: 415954529, 434199505
Original change's description:
> Allow Loopback AEC on Mac only when Catap loopback is available
>
> Bug: 415954529
> Change-Id: Ic7b0bb1f3a6e9c93aafc51ebcf15d1636baa6009
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6787811
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Commit-Queue: Guido Urdaneta <guidou@chromium.org>
> Auto-Submit: Olga Sharonova <olka@chromium.org>
> Commit-Queue: Olga Sharonova <olka@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1492077}
Bug: 415954529
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I8d1ae11208009493b0b42a90cf55c5f7113c0ec6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6788259
Commit-Queue: Darryl James <dljames@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Darryl James <dljames@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1492124}
mac installer: Rewrite brand codes more extensibly.
Specifically this allows FPAF <-> FPJF and FPAD <-> FPJD, which are
needed for the associated bugs, but it seems both concise and more
maintainable to just define the bimapping over the entire GCE*/GCC* and
FPA*/FPJ* ranges.
Also, reorganized the tests a little bit.
Bug: 427739042, 427746789
Change-Id: I919d8170798cf5a6a53af75349f29b9e23fab0a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6788729
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Auto-Submit: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1492123}
[declutter] Update the message card IPH subtitle to be shorter
Shorten then the message card IPH subtitle for the declutter entrypoint.
Bug: 431818271
Change-Id: I722318b5b108e4ad9256acd247cdb46ff1932b09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6786410
Commit-Queue: Brandon Fong <bjfong@google.com>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1492122}
Roll optimization-guide from 163d2f7845e6 to 0a8ac7a60d69
https://chrome-internal.googlesource.com/chrome/components/optimization_guide.git/+log/163d2f7845e6..0a8ac7a60d69
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/optimization-guide-chromium
Please CC chrome-ai-ondevice-eng-core@google.com,chrome-ai-ondevice-eng@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:401000296
Change-Id: I6c22feada68a00d962c54fe0b3aec0089b4a8e61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6788451
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1492121}
Update ShouldNotifyAboutFillingOnPageload to check for leaks
This CL updates ShouldNotifyAboutFillingOnPageload to check if
password is leaked. This allows to narrow experiment activation to
include only users who can possible see the password change feature.
Now it also checks for GetChangePasswordUrlOverride to get correct
behavior during testing.
Bug: 392020509
Change-Id: I5b958c70fbbc59bcfcf062c5d3335000018f2430
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6783730
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com>
Cr-Commit-Position: refs/heads/main@{#1492120}
Do not record password change login outcome on second login
This swaps the order of timestamp recording for the backup password and
`date_last_used` on pending credentials. This ensures that newly added
backup passwords have earlier timestamp than the date_last_used.
`date_last_used` is recorded on each successful login. This means that
if it's greater than the backup password creation timestamp, there was
already a successful login after the password change flow.
Bug: 430012101
Change-Id: Iabfdeff35481e5f8b8776d5729904ad0792c1341
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6779375
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Auto-Submit: Oleksandr Tara <otara@google.com>
Cr-Commit-Position: refs/heads/main@{#1492119}
Add helper class to handle underline UI triggering
This CL omits handling of one required signal, being changes to the set of pinned tabs. This will be added in a follow up change.
Bug: b:431791050
Change-Id: Ic2d90e11cbd34ae1fdeb79e4ba0ddfbd0550b224
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6778268
Reviewed-by: Ian Wells <iwells@chromium.org>
Commit-Queue: Anthony Cui <cuianthony@chromium.org>
Reviewed-by: Alison Gale <agale@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1492118}
[OSmosis] Attach rust library to stable portability data importer
This CL adds the plumbing required to call the rust library
in order to parse the history data and integrate it into
the stable portability data importer.
The rust library receives a path, and returns results in
batches. The `StablePortabilityDataImporter` accumulates
the results in its `pending_history_entries_` vector.
This implementation also adds a basic test that checks that
a JSON data can be correctly imported.
Bug: 430253028
Change-Id: I039cfbe0f67dc18824922019c147a20baf73e623
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6771997
Auto-Submit: Michael Tatarski <mtatarski@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1492117}
Roll Perfetto from ab99948900d2 to fbf4761bef94 (2 revisions)
https://chromium.googlesource.com/external/github.com/google/perfetto.git/+log/ab99948900d2..fbf4761bef94
2025-07-25 lalitm@google.com tp: don't enforce column schema documentation in G3 (#2319)
2025-07-25 108405710+aMayzner@users.noreply.github.com exp: Handle nodes overlapping better (#2318)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC etiennep@google.com,perfetto-bugs@google.com,primiano@chromium.org on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: etiennep@google.com,perfetto-bugs@google.com
Change-Id: Ia16bddb84df4f6939ecaf5451b21158b6ab07072
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6788789
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1492116}
Roll V8 from 920a557bf76d to 65f38d1710e2 (5 revisions)
https://chromium.googlesource.com/v8/v8.git/+log/920a557bf76d..65f38d1710e2
2025-07-25 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Version 14.0.309
2025-07-25 victorvianna@google.com Remove references to enable_nacl from //v8
2025-07-25 nikolaskaipel@google.com [fuzzer][wasm] add shared-everything instructions to libfuzzer
2025-07-25 zhaojiazhong-hf@loongson.cn [loong64][codegen] Avoid memory access under stack pointer
2025-07-25 clemensb@chromium.org Rename LazyBuiltinsAssembler to JSTrampolineAssembler
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/v8-chromium-autoroll
Please CC liviurau@google.com,machenbach@google.com,v8-waterfall-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chrome.try:linux-perf-trigger
Change-Id: Ibf47e69f3fd31c8534afe8c1208c95211a833dd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6788771
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1492115}
[comments] Add scaffold for syncer::SHARED_COMMENT sync datatype.
Adds the new DataType enum value and the definition of the specifics.
Mostly generated from components/sync/bootstrap_new_data_type.sh.
Note to sync reviewer: please verify for every touched static_assert(),
the change is fitting or has a corresponding TODO.
Bug: b:433556051, b:433963535
Change-Id: Ib4b089152d56bdc6cfc0118d97a8a05386701504
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6778366
Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1492114}
Roll gn from e9fc92ac17de to 4cfb717bbd5e
https://gn.googlesource.com/gn.git/+log/e9fc92ac17de..4cfb717bbd5e
2025-07-25 tikuta@google.com Update macOS version to 13 used in CQ/CI
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/gn-chromium-autoroll
Please CC dpranke@chromium.org,dpranke@google.com,thakis@chromium.org,tikuta@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: dpranke@chromium.org,thakis@chromium.org,tikuta@google.com
Change-Id: I226c54502dbab8674abfde981e8a11f154983f00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6787747
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1492113}
Roll Help App from WD-hMS8wvD10CwUeT... to 8HCavCw71ocEmMOOL...
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202507250800_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/8HCavCw71ocEmMOOLjxNbaTzHnKxteSRoQ0n1SV-rF8C
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll
Please CC cros-essential-apps-dev@chromium.org,help-app@grotations.appspotmail.com,jomag@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: help-app@grotations.appspotmail.com
Change-Id: Ib6924e740fe1203b5568aa8b3a4a44edbfd262c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6788428
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1492112}
Remove unused PrefService parameter from IsGmsCoreUpdateRequired()
It became unused in crrev.com/c/6700816.
Fixed: 433682805
Change-Id: I482339a9c0766374c7386b5a56b91135d8bcc2cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6787871
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Victor Vianna <victorvianna@google.com>
Cr-Commit-Position: refs/heads/main@{#1492111}
Remove PasswordManager.UnifiedPasswordManager.ActiveStatus2 histogram
Split off from here.
https://chromium-review.googlesource.com/c/chromium/src/+/6700816/comment/d55c82a4_d854d24c/
OBSOLETE_HISTOGRAMS=Expired and no longer needed.
Fixed: 41486742
Change-Id: Ic3d55be9f869853461e12a74b8f7fcb6387a652e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6787930
Reviewed-by: Viktor Semeniuk <vsemeniuk@google.com>
Commit-Queue: Victor Vianna <victorvianna@google.com>
Cr-Commit-Position: refs/heads/main@{#1492110}
[passwords/android] Limit kPasswordsUseUPMLocalAndSeparateStores access
No behavior change.
Instead of allowing arbitrary reads/writes to this three-state pref
(kOff/kOffAndMigrationPending/kOn), this CL exposes a minimal API to
satisfy production needs. This should prevent bugs like
crbug.com/428667627 and make it easier to get rid of the pref in the
future. The API consists of:
1. (existing) A bool getter which treats kOff and
kOffAndMigrationPending alike. It is renamed to include "Legacy"
and thus discourage new usages.
2. (new) A test-only bool setter. The pref is not updated in production
ever since LoginDbDeprecationAndroid launched.
3. (new) A function for pref registration.
Besides that:
* Rename SetUsesSplitStoresAndUPMForLocal() to
MaybeDeleteLoginDatabases(), since it doesn't set the pref at all
anymore.
* Stop unnecessarily setting the pref in tests where
UsesSplitStoresAndUPMForLocal() is never called (verified by
temporarily replacing the implementation with NOTREACHED and observing
whether the test crashes).
This definition of "unnecessary" is rather conservative, but handling
more tests is left for future CLs.
After this CL the legacy pref is only read in these places (only public
APIs are listed, not internal helpers):
* MaybeDeleteLoginDatabases()
* IsPasswordManagerAvailable()
* LoginDbDeprecationReady()
* LoginDbDeprecationRunnerFactory::GetForProfile()
Bug: 433682805
Change-Id: I987c653cdae9d9c862b80686950902dac9d27e9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6691158
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Victor Vianna <victorvianna@google.com>
Cr-Commit-Position: refs/heads/main@{#1492109}