chromium tree closers
Legend: | Passed | Failed | Running | Exception |
media: Add a missing include
This is to prevent build error like
https://ci.chromium.org/ui/p/chromium/builders/ci/linux-v4l2-codec-rel/141667/overview
Bug: 40263312
Change-Id: I14ee0aa74d039a9d598c4d74bd31e78de8565516
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6782440
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Owners-Override: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Junji Watanabe <jwata@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1491292}
Support loading unpacked extensions on Android desktop
It's confirmed that simple extensions just having manifest.json and
rules.json work. background.js also works.
Bug: 406136787
Change-Id: I899044853f7d84a9d02adfcb85ea5ab230343434
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6628991
Commit-Queue: Keigo Oka <oka@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1491291}
Improve Android file handling for virtual document paths
This change enhances file handling on Android, particularly for virtual document paths.
It introduces `OpenAndroidFile` to centralize platform-specific file opening logic. A new `createIfNotExist` method is added to `VirtualDocumentPath`, allowing for the creation of empty files.
This commit also fixes an issue where file flags like `FLAG_OPEN_ALWAYS` and `FLAG_CREATE` were not correctly translated to the proper Android mode strings for content URIs.
To ensure correctness, a new test suite is included to validate file creation and opening flags for virtual document paths.
Bug: 406136787
Change-Id: Ifaac2ab164748def442ced6d731c5ceb33a9ffd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6774464
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Keigo Oka <oka@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1491290}
buildtools: Fix module deps for macOS
Bug: 425535758
Change-Id: If5a57a367b3d1a0b52a8089a391832b1891b8cd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6780007
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1491289}
Roll Chrome Android ARM64 PGO Profile
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1753331281-bee8d7e01f86d5a4e7577f1a05d677a34f86d8ce-30b32007873b6e86ecc636deef4814b60cfd0916.profdata to chrome-android64-main-1753335536-a89a889a7fc650d951296b83c970c0d5e55e751c-bd976830535e46b03ad93adef26d55e4b65f7606.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I22d1de4802e611ab452886195d0d55fd7c9357de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6781893
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1491288}
Fix typo in a method name
Bug: none
Change-Id: Ia61cecce045eaa0a633a6dda8c294d2dd4e1d081
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6779786
Reviewed-by: Ewann Pellé <ewannpv@chromium.org>
Auto-Submit: Louis Romero <lpromero@google.com>
Commit-Queue: Louis Romero <lpromero@google.com>
Cr-Commit-Position: refs/heads/main@{#1491287}
Remove unused shared tab groups util
The alerts are presented via the collaboration delegate now:
- https://source.chromium.org/chromium/chromium/src/+/main:components/collaboration/public/collaboration_controller_delegate.h;l=111;drc=aaafac3d6ae6f8f57b3a2f64f44394df325cf8c8
- https://source.chromium.org/chromium/chromium/src/+/main:ios/chrome/browser/collaboration/model/ios_collaboration_controller_delegate.mm;l=180-181;drc=839827bac687e9f9c265a5c1870e7df2c669acda
The last usage was removed downstream in internal review 7910527.
Bug: 403251241
Change-Id: I9d4e45bf545df4ccdcce3dc19405f7f5c278ac72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6780465
Commit-Queue: Louis Romero <lpromero@google.com>
Reviewed-by: Ewann Pellé <ewannpv@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1491286}
Revert "Add kAccountNameEmail member to AutofillProfile::RecordType enum."
This reverts commit 2ac820e157bd6a2bb97f92d859f3c0b71d8b6970.
Reason for revert:
LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8708482450808357665
Sample failed build: https://ci.chromium.org/b/8708482450808357665
If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6727955&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8708482450808357665&type=BUG
Original change's description:
> Add kAccountNameEmail member to AutofillProfile::RecordType enum.
>
> There are changes in idl file: autofill_private.idl
>
> Bug: 356845298
> Change-Id: If648ab480e88e374f97d0c10acd33352834edb43
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6727955
> Reviewed-by: John Lee <johntlee@chromium.org>
> Reviewed-by: Tim <tjudkins@chromium.org>
> Commit-Queue: Paweł Stus <pawelstus@google.com>
> Reviewed-by: Florian Leimgruber <fleimgruber@google.com>
> Reviewed-by: Karol Sygiet <sygiet@google.com>
> Cr-Commit-Position: refs/heads/main@{#1491279}
>
Bug: 356845298
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Icee2a6c8fddc40db7e8feb7dc8c7ae8f4c1c62c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6782508
Bot-Commit: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com>
Owners-Override: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com>
Commit-Queue: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1491285}
Revert "build: Enable clang modules build on Linux by default"
This reverts commit fdaa45de9ed81b1ede413b76c37b52856bf7d2dd.
Reason for revert:
LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8708482642947360305
Sample failed build: https://ci.chromium.org/b/8708482642947360305
If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6703261&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8708482642947360305&type=BUG
Original change's description:
> build: Enable clang modules build on Linux by default
>
> This will save 13% of cpu usages in chrome build, 11% of chrome build
> time when using local machine.
>
> But if this causes build failure in CQ/CI, feel free to revert this CL.
>
> PSA for this CL is sent to chromium-dev as
> https://groups.google.com/a/chromium.org/g/chromium-dev/c/oChiBMoGFvU
>
> Bug: 428778692
> Change-Id: I6a00b1c387a5b1e7227f7aecb5f3b6e7a6843d2a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6703261
> Reviewed-by: Junji Watanabe <jwata@google.com>
> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1491278}
>
Bug: 428778692
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I34ce54d10774389f72f22cda4aaec9cad7ba36ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6778494
Owners-Override: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com>
Commit-Queue: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com>
Bot-Commit: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1491284}
Re-enable layout test and updated copy-network-request-expected.txt
- Updated expectations file
- Re-enabled test in TestExpectations
Change-Id: I5c257cc7a4c8719768ced52fd64b21ad24abb3be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6781242
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1491283}
[//media] Restore data verification in GMBVideoFramePool NV12 input test
Map the data via the generated mappable SI rather than the previous
mechanism of mapping it via the (no-longer-created) GpuMemoryBuffer.
Note that the test is the same one as was being done previously ([1],
line 639).
[1]
https://chromium-review.googlesource.com/c/chromium/src/+/6733268/4/media/video/gpu_memory_buffer_video_frame_pool_unittest.cc
Bug: 366375486
Change-Id: Ic3b12a8643e86a7eb1219b0f4d43be829984902b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6780621
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1491282}
[//media] Restore verification of data in 10Bpp GMBVideoFramePool test
Map the data via the generated mappable SI rather than the previous
mechanism of mapping it via the (no-longer-created) GpuMemoryBuffer.
Note that the test is the same one as was being done previously ([1],
line 430), with the exception that the Y and V checks need to be
flipped as the output is in YV12.
[1]
https://chromium-review.googlesource.com/c/chromium/src/+/6733268/4/media/video/gpu_memory_buffer_video_frame_pool_unittest.cc
Bug: 366375486
Change-Id: I3542a71353e45becbcdebad965fec8826a3a0d9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6778204
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1491281}
Do not crash when trying to edit a parentless node
This fixes a crash happening when devtools first duplicates then edits
a body node.
Fixed: 346929064
Change-Id: Id3e6778a0b904aac888b3288c312426d31c58821
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6779587
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1491280}
Add kAccountNameEmail member to AutofillProfile::RecordType enum.
There are changes in idl file: autofill_private.idl
Bug: 356845298
Change-Id: If648ab480e88e374f97d0c10acd33352834edb43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6727955
Reviewed-by: John Lee <johntlee@chromium.org>
Reviewed-by: Tim <tjudkins@chromium.org>
Commit-Queue: Paweł Stus <pawelstus@google.com>
Reviewed-by: Florian Leimgruber <fleimgruber@google.com>
Reviewed-by: Karol Sygiet <sygiet@google.com>
Cr-Commit-Position: refs/heads/main@{#1491279}
build: Enable clang modules build on Linux by default
This will save 13% of cpu usages in chrome build, 11% of chrome build
time when using local machine.
But if this causes build failure in CQ/CI, feel free to revert this CL.
PSA for this CL is sent to chromium-dev as
https://groups.google.com/a/chromium.org/g/chromium-dev/c/oChiBMoGFvU
Bug: 428778692
Change-Id: I6a00b1c387a5b1e7227f7aecb5f3b6e7a6843d2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6703261
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1491278}
build: Enable -fno-math-errno by default
This is to address
https://chromium-review.googlesource.com/c/chromium/src/+/6712879/comments/9c035bdd_c2c11538
Bug: 428778692
Change-Id: Ib4cdb8c7b2933c4597fa3f160ad6ecff47c06e6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6778942
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1491277}
Roll src/net/third_party/quiche/src/ 12f908334..d76b2b7a8 (18 commits)
https://quiche.googlesource.com/quiche.git/+log/12f908334b43..d76b2b7a880b
$ git log 12f908334..d76b2b7a8 --date=short --no-merges --format='%ad %ae %s'
2025-07-23 elburrito BlindSignAuth: Remove `UnpackTo` usage in tests
2025-07-21 quiche-dev Fix build error in Chromium
2025-07-21 vasilvv Simplify the way bitrate adjuster provides bitrate feedback.
2025-07-21 elburrito BlindSignAuth: Serialize `AndroidAttestationData` into an `Any` proto instead of using `PackFrom`. QUICHE uses lite protos and doesn't have reflection or descriptors.
2025-07-21 abhisinghx Modify Masque Client to create a CONNECT-UDP-Bind client
2025-07-18 martinduke Terminate MoQT subscription with TooFarBehind if largest group is abandoned and DELIVERY_TIMEOUT is infinite.
2025-07-18 martinduke Update version number to MoQT draft-12.
2025-07-18 martinduke Update MoQT AuthorizationTag parameter to draft-12.
2025-07-17 martinduke Remove `kGroupDoesNotExist` Moqt status.
2025-07-16 rch Remove unused method QuicSpdySession::CreateOutgoingUnidirectionalStream and QuicSpdySession::ShouldCreateOutgoingUnidirectionalStream.
2025-07-16 vasilvv Use C++20 default operators in MoQT code.
2025-07-15 asedeno Fix up minor issues in quiche export.
2025-07-15 martinduke Update MoQT datagrams to draft-11.
2025-07-14 martinduke Deprecate --gfe2_reloadable_flag_quic_heapless_static_parser.
2025-07-14 martinduke Use the default operator== in moqt_messages.h.
2025-07-14 haoyuewang Deprecate --gfe2_reloadable_flag_quic_record_tos_byte
2025-07-14 martinduke Update Subgroup Stream Header formats to draft-11.
2025-07-14 elburrito BlindSignAuth: Implement GetAttestationTokens API.
Created with:
roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src
Change-Id: Iebdeb7c736de8ec35a7188f1ea39b458fe0df196
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6780426
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Auto-Submit: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1491276}
[Blink] Have HTMLCanvasElement call GetOrCreateCRP() explicitly
It currently does this indirectly by calling
CanvasRenderingContext::IsCanvas2DResourceValid() [1]. There are two
problems with this indirection:
* It looks like a simple accessor but it's actually mutating state
* More importantly, if we were ever to get here and need to wake up
from hibernation it's flat-out *wrong*, as it won't recreate the CRP
and we'll crash later on in the method.
Of course, we want to eliminate HTMLCanvasElement explicitly asking for
the CRP to be created here in the medium term, but that's a distinct
challenge that is made more visible by this change.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/6780628/1/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.cc
Bug: 352263194
Change-Id: Icfb64288a9d58ae98774ab9d455e6b3d012fe002
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6781227
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1491275}
[Blink] Streamline CanvasRenderingContext2D::IsCanvas2DResourceValid()
The code being removed here is redundant, as
GetOrCreateCanvasResourceProvider() will already fail in both of these
cases [1] (note: IsContextBeingRestored() will be true only here [2],
which is distinct from IsCanvas2DResourceValid() callsites).
[1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.cc;l=1288-1307;drc=4eaa7ecc4adc54dc936063562327f3d0c599f403
[2] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.cc;l=272-273;drc=a3c9c4dcd0d6de500f41d7272d9515b6b81b7729
Bug: 352263194
Change-Id: I0aa185032e19206d8cdb886841139f6a5b349a8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6780628
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1491274}
[Blink] Eliminate BaseRC2D::IsCanvas2DBufferValid()
This method is confusing:
* The CanvasRenderingContext2D and OffscreenCanvasRenderingContext2D
implementations are very different.
* CanvasRenderingContext2D has a very similar (but not identical)
IsCanvas2DResourceValid(), and it's not clear what the differences in
semantics would rationally be.
This CL eliminates the method by:
* Removing using it as an early out in
BaseRenderingContext2D::putByteArray()
* Inlining its respective impls at the front of
(Offscreen)CanvasRenderingContext2D::WritePixels().
BaseRC2D::putByteArray() just calls through to WritePixels(), and
WritePixels() has no other callers.
Bug: 352263194
Change-Id: Id5c4b9110ca57d70785e9cbf142d193824fe9fbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6781184
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1491273}
[//ui] Remove CreateBufferAsync()
Nothing uses this method at this point.
Bug: 404905709
Change-Id: Ib708981c93ea45aba912498447e05ff15f7a6b18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6780901
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1491272}
[Blink] Eliminate calling ImageBitmapRenderingContext::IsAccelerated()
The one callsite of this method for ImageBitmapRenderingContext is here
[1]. That method's one production callsite is here [2]. The
ImageBitmapRC implementation of IsAccelerated() checks whether the
context's CanvasResourceProvider exists and is accelerated. However,
ImageBitmapRenderingContext creates its CRP only when pushing a frame
for OffscreenCanvas (i.e., offscreen canvas with a placeholder). Hence,
the current behavior when the source is an ImageBitmap canvas is the
following:
* HTMLCanvasElement: will never accelerate
* OffscreenCanvas with placeholder: Will accelerate if source image is
accelerated, but this is essentially coincidental (e.g., we are
looking to remove usage of CRP in that flow in the near-term)
* OffscreenCanvas without placeholder: Will never accelerate
This CL changes this flow to use whether the source image is
texture-backed to determine whether the source is accelerated for
source ImageBitmap canvases. This fixes the flows described above.
[1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.cc;l=186;drc=d0cdb873a9f5d9b6ef2696f65cdd80b619240b14;bpv=1;bpt=1
[2] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/html/canvas/html_canvas_element.cc;l=1924;drc=d0cdb873a9f5d9b6ef2696f65cdd80b619240b14
Bug: 352263194
Change-Id: If422849649bb387d0963f542377b60e0e4129779
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6779344
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1491271}
[//ui] Remove CreateNativePixmapAsync()
Nothing uses this method at this point.
Bug: 404905709
Change-Id: I3bc05430fd42719f4f6cb53ece321ebe8ad8debe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6780941
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1491270}
[//media] Re-enable tests on Mac
The tests set an 8-bit value but read it back as a 16-bit value,
assuming that the "unset half" of the value is 0. Zero-initialize the
data in question rather than leaving it uninitialized in order to make
this work as expected.
Bug: 366375486
Change-Id: I511e5b6278af54fcfe8ed8930d4f0c125b530c16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6771798
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1491269}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1753293557-1e5f5de80b7fe2c07413d277b32fb2f829caace6-130e6845bbaaef3059f8518d8c550d9f4084401f.profdata to chrome-win32-main-1753314684-35ef504bcfd964c8692b76560fdea8511850a5b5-701ac6259b6182382cbebd32369b58c64a99d12f.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: Ie0208c0f1363821ddc4c18c2b0307e2126d418fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6777899
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1491268}
Disable a test in DeepScanningReportingSourceTypeTest on Windows
This CL disables
`DeepScanningReportingSourceTypeTest.ProcessesResponseCorrectly` due to
flakiness.
Bug: 433865922
Change-Id: I6568ef700ed66be9bded3c5d8121beb0d1b97f74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6782065
Reviewed-by: Shunya Shishido <sisidovski@chromium.org>
Owners-Override: Keita Suzuki <suzukikeita@chromium.org>
Commit-Queue: Shunya Shishido <sisidovski@chromium.org>
Auto-Submit: Keita Suzuki <suzukikeita@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1491267}
Roll V8 from 34526631fbd7 to 75f58bf8c6dd (4 revisions)
https://chromium.googlesource.com/v8/v8.git/+log/34526631fbd7..75f58bf8c6dd
2025-07-24 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Version 14.0.300
2025-07-24 yahan@iscas.ac.cn [riscv] Optimize emit of sext.w when CompareZero/WordShl/Word32Shr/Word32Sar
2025-07-23 manishearth@google.com [temporal] Use new get_epoch_ns_for() API for Intl
2025-07-23 jkummerow@chromium.org [wasm-custom-desc] Add ConfigureAllPrototypesOpt builtin
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/v8-chromium-autoroll
Please CC liviurau@google.com,machenbach@google.com,v8-waterfall-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chrome.try:linux-perf-trigger
Change-Id: I3e3aa3e5cc74941b8067c3aa6f065b265bc9a2ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6782619
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1491266}
Roll Depot Tools from 5ce80c825163 to 9cf131bdaadf (1 revision)
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5ce80c825163..9cf131bdaadf
2025-07-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC chops-source-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-utr-tester;luci.chromium.try:win-utr-tester
Bug: None
Tbr:
Change-Id: I3490d38ec66f89ba764a8306c3f7cedc1c358320
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6782028
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1491265}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1753282773-9ff150ff83e0015e7bf29c3a08593d4b1b6cc8ff-32093f0b1887f58ac9849a01921abe9ebdd6e770.profdata to chrome-win64-main-1753314684-04721f8770c75f2c9f247c8dd591c3efda4071bf-701ac6259b6182382cbebd32369b58c64a99d12f.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: Idd1203eceb95b43d380cc52ef7b111551670096b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6782153
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1491264}
Roll Chrome Android ARM64 PGO Profile
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1753327782-11ce9f6d91fa4d90ca5289625ce9c6db0e6617b9-cff8173dc17c32f64c910b116c5ef05fb56daddd.profdata to chrome-android64-main-1753331281-bee8d7e01f86d5a4e7577f1a05d677a34f86d8ce-30b32007873b6e86ecc636deef4814b60cfd0916.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I13c5d0e5935ecbd48fdb1a3864f94fa387cbc99d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6782264
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1491263}
Remove unused include in preconnect_manager_impl.cc
Should save ~5 MiB of compiler input size.
Bug: 40318405
Change-Id: Iad00848e039d3e6c494b1a24d9ffe5540507f6b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6782507
Commit-Queue: David Sanders <dsanders11@ucsbalum.com>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1491262}
Roll goldctl (mac) from B7EcDAL2Fh_20K0Ud... to hZpj0hRnYNFplpUOc...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll
Please CC bsheedy@chromium.org,kjlubick@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in goldctl (mac): https://bugs.chromium.org/p/skia/issues/entry?owner=kjlubick@google.com
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: bsheedy@chromium.org
Change-Id: I98041e398c3f968ca9b930591b726d39937811a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6782621
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1491261}
[CompositeClipPathAnimation] Add test for setStartTime
Related to recent fixes for animation retargets, this test
ensures JS calls to setStartTime do not cause unexpected issues
with cc clip path animations
Bug: 40503852
Change-Id: Id95bd0b91f83931dcd0d73a76f3551405f1dbb68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6732684
Commit-Queue: Claire Chambers <clchambers@microsoft.com>
Reviewed-by: Olga Gerchikov <gerchiko@microsoft.com>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1491260}
Roll Infra from e7eba484af07 to efbba6418643
https://chromium.googlesource.com/infra/infra.git/+log/e7eba484af07..efbba6418643
2025-07-24 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll luci-go from f801a0983385 to af7df56f923e (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/infra-chromium
Please CC iannucci@google.com,luci-eng@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: iannucci@google.com
Change-Id: I1cf99400e4c69c6103bbd1752b6806b84a01c723
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6782259
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1491259}
[CompositeClipPathAnimation] Add tests for setting time & duration
This CL adds 3 tests that cause the animation to change out of its
current state, either before or after the active phase, to ensure
correctness for composited clip path animations.
Bug: 40503852
Change-Id: Iba5cb8a192e27d0c01911e54707389abeaa88c97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6732702
Reviewed-by: Olga Gerchikov <gerchiko@microsoft.com>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Commit-Queue: Claire Chambers <clchambers@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1491258}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1753322388-1c8ee100d641d8df0e257144a45ced880f5ff181-0b50b83d7110b9015ccd0903bc9a4b1412d4c69b.profdata to chrome-mac-arm-main-1753329296-e7d8a6dec1d78ec51d8771e01b67e408e89cd1e4-bad989a1109bce64b0f0dc9c54fe344034832127.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I555bc332150b0278263fbc4a2f24123f0526f39d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6782505
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1491257}
Turn HarfBuzz given range `DCHECK` to `CHECK` (part 2)
crrev.com/c/6782438 missed one more variant of
`HarfBuzzShaper::Shape()`. This patch changes it to `CHECK`.
Bug: 433647419
Change-Id: I8f826ad7eb94883e87ff56de76798b7c47fe2a0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6780169
Commit-Queue: Kent Tamura <tkent@chromium.org>
Auto-Submit: Koji Ishii <kojii@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1491256}
Roll DevTools Frontend from eb970fbc6482 to 8809501a6cd8 (1 revision)
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/eb970fbc6482..8809501a6cd8
2025-07-24 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Roll browser-protocol
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC liviurau@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: I51fb4d6357444223d68119d4c4edbfae3d4230d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6782626
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1491255}
Make fields of `ShapeResultRun` private
All fields were public for historical reasons. This patch
changes them to private, with some deeply integrated classes
added to friends.
This patch has no behavior changes.
Change-Id: Ic4710568fd76ee629f85dffcbace5227c42d74e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6777481
Reviewed-by: Kent Tamura <tkent@chromium.org>
Auto-Submit: Koji Ishii <kojii@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1491254}
Roll goldctl (mac arm64) from wf6bkz0nbOmOa5raA... to ulgsu9nJXlCe-TeAX...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/goldctl-mac-arm64-chromium-autoroll
Please CC bsheedy@chromium.org,kjlubick@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in goldctl (mac arm64): https://bugs.chromium.org/p/skia/issues/entry?owner=kjlubick@google.com
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: bsheedy@chromium.org
Change-Id: I938dd6121036ccdac9edb796e50e15f0d50ba7dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6782620
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1491253}
[WebNN] Implement DequantizeLinear and QuantizeLinear operations for ORT backend
Bug: 432136553
Change-Id: I79abe84a0f2a732f30243d52f651ade2ab9639d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6759793
Commit-Queue: Wei4 Wang <wei4.wang@intel.com>
Reviewed-by: Phillis Tang <phillis@chromium.org>
Reviewed-by: ningxin hu <ningxin.hu@intel.com>
Cr-Commit-Position: refs/heads/main@{#1491252}
[PasswordChange] Fix toast transition glitch
Calling SetPreferredSize() on layout updates for the action button
creates a flickering effect because of the layout being invalidated and
button being drawn on the left and then moved to the right side of the
toast.
SetPreferredSize() seems unnecessary anymore given the changes to
TabDialogManager that happened in the meantime (for resizing/animating
the toast automatically on transitions), which should handle the new
preferred size after label change correctly.
Bug: b:433496206
Change-Id: I2c5bf51c22acc740313f65b57ebdeb7a711ca0d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6781226
Commit-Queue: Rafał Godlewski <rgod@google.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1491251}
Roll goldctl (linux) from Vo1Pp2yAU3s1kNKpv... to Sg25-ZztJqPtMF0rP...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll
Please CC bsheedy@chromium.org,kjlubick@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in goldctl (linux): https://bugs.chromium.org/p/skia/issues/entry?owner=kjlubick@google.com
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: bsheedy@chromium.org
Change-Id: I43132955f0a9958a841374e56833236839fa0d4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6782483
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1491250}
Roll goldctl (win) from eJjdTeKFcLju_kN2-... to 0sP0Mad75mVvpE0TL...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/goldctl-win-chromium-autoroll
Please CC bsheedy@chromium.org,kjlubick@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in goldctl (win): https://bugs.chromium.org/p/skia/issues/entry?owner=kjlubick@google.com
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: bsheedy@chromium.org
Change-Id: Id8440931d74dc765600e1060a3fe109b2df44b55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6782482
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1491249}
Disable flaky NoCrashOnEventsDuringHandlerPrint test on Mac.
Disable the flaky test on Mac.
Bug: 433855037
Change-Id: Ia7876dedb78e7b1cefd031df5f00908531617534
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6782419
Owners-Override: Keita Suzuki <suzukikeita@chromium.org>
Commit-Queue: Keita Suzuki <suzukikeita@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1491248}
[PA] Move Metadata outside of GigaCage (4/6)
Replace the code for shadow metadata initialization with external
metadata one, i.e. allocates virtual address space for metadata and
initializes offsets. Remove `EnableShadowMetadata()`-related code.
Design Doc:
https://docs.google.com/document/d/1Mn-qRAWuDhS_gRL_OG2TYL-EW5D8yljaCyM40S0ocVc/edit?tab=t.0
Bug: crbug.com/40238514
Change-Id: Icca2cbbc1d7245d56202b2c451cc3e40e8624484
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6759630
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/main@{#1491247}
[PasswordChange] Update settings strings
Updates the strings to match the mocks and adds UXW description notes.
Mock: https://screenshot.googleplex.com/Aj2pTEiCrNp6d4L
Impl: https://screenshot.googleplex.com/5mGdH2XaUSfxDR7
Fixed: b:433631828
Change-Id: I6e1de4274ce626fa4777fd5a47eef01083354b8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6779761
Commit-Queue: Rafał Godlewski <rgod@google.com>
Reviewed-by: Viktor Semeniuk <vsemeniuk@google.com>
Reviewed-by: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1491246}
[Nav Bar Color Animations] Enable flag by default
Removed field trial testing config and enabled flag by default for the launch. The unit tests will fixed during the flag cleanup.
Bug: 425761643
Change-Id: I9085575203dfd93c1aa758fd0314893e98f63233
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6782578
Commit-Queue: Eleanor Lee <eleanorlee@google.com>
Reviewed-by: Wenyu Fu <wenyufu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1491245}
[fetch-retry] Add dedicated UseCounter for RetryOptions
According to [previous discussion][1], the `Measure` IDL annotation doesn't work for dictionary fields.
[1]: https://chromium-review.googlesource.com/c/chromium/src/+/6758857/4..13/third_party/blink/renderer/core/fetch/request_init.idl#b36
Bug: 417930271
Change-Id: Icaf750ebe50edfa4b3b56eb8ff25823b0303e96c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6782308
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Ming-Ying Chung <mych@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1491244}
Turn HarfBuzz given range `DCHECK` to `CHECK`
When the given range is invalid, such as `end < `start`,
HarfBuzz can cause severe errors including `SECURITY_DCHECK`.
This patch changes `DCHECK` on the entry to `CHECK`. This
makes it easier to distinguish whether errors come from
invalid arguments in the callers or from HarfBuzz itself.
Bug: 433647419
Change-Id: I0afba2ce1e0fc16f6b103d0abe4305f048066618
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6782438
Auto-Submit: Koji Ishii <kojii@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1491243}