+
Skip to content

Adding option for GitHub annotations #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 15, 2025
Merged

Adding option for GitHub annotations #45

merged 4 commits into from
Sep 15, 2025

Conversation

abdelq
Copy link
Contributor

@abdelq abdelq commented Sep 14, 2025

Closes #42

@kusari-inspector Kusari Inspector
Copy link

kusari-inspector bot commented Sep 14, 2025 •
edited
Loading

Kusari Inspector

Kusari Analysis Results:

Proceed with these changes

✅ No Flagged Issues Detected
All values appear to be within acceptable risk parameters.

No pinned version dependency changes, code issues or exposed secrets detected!

Note

View full detailed analysis result for more information on the output and the checks that were run.

@kusari-inspector rerun - Trigger a re-analysis of this PR
@kusari-inspector feedback [your message] - Send feedback to our AI and team
See Kusari's documentation for setup and configuration.
Commit: 6ac42b7, performed at: 2025-09-14T15:09:21Z

Found this helpful? Give it a 👍 or 👎 reaction!

@woodruffw
Copy link
Member

Thanks for the PR @abdelq! I'll be able to review this in a bit.

@woodruffw
make input split stricter
8d1fd02 
Signed-off-by: William Woodruff <william@yossarian.net>
@kusari-inspector Kusari Inspector
Copy link

Kusari PR Analysis rerun based on - 8d1fd02 performed at: 2025-09-15T00:27:15Z - link to updated analysis

@woodruffw
selftest
d8ff9bc 
Signed-off-by: William Woodruff <william@yossarian.net>
@kusari-inspector Kusari Inspector
Copy link

Kusari PR Analysis rerun based on - d8ff9bc performed at: 2025-09-15T00:32:53Z - link to updated analysis

@woodruffw
add positive test
6ac42b7 
Signed-off-by: William Woodruff <william@yossarian.net>
@kusari-inspector Kusari Inspector
Copy link

Kusari PR Analysis rerun based on - 6ac42b7 performed at: 2025-09-15T00:34:03Z - link to updated analysis

woodruffw
woodruffw approved these changes Sep 15, 2025
View reviewed changes
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @abdelq!

I've added some tests and made this a bit stricter -- I've made it a hard error to use both options instead of a warning.

@woodruffw woodruffw merged commit e673c39 into zizmorcore:main Sep 15, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@woodruffw woodruffw woodruffw approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

No way to set annotations by using --format=github

2 participants

@abdelq @woodruffw
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载