-
-
Notifications
You must be signed in to change notification settings - Fork 5
fix: allow version prefix of v
#31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Allow the `version` input to be prefixed with `v`.
Kusari Analysis ResultsAnalysis for commit: 972c1ee, performed at: 2025-08-12T12:32:55Z • • Recommendation✅ PROCEED with this Pull Request Summary✅ No Flagged Issues Detected All values appear to be within acceptable risk parameters. No pinned version dependency changes, code issues or exposed secrets detected! Found this helpful? Give it a 👍 or 👎 reaction! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a validation issue where the action's version input couldn't accept version strings prefixed with v
, despite the README documenting this feature. The fix updates the regex validation pattern and strips the v
prefix when constructing the Docker image tag.
- Updates version validation regex to accept optional
v
prefix - Strips
v
prefix from version string when building Docker image tag
Hi @martincostello, thanks for the PR! That's actually an error in the README 😅 -- I originally intended for it to be the exact tag at it appears on zizmor's Docker images: https://github.com/zizmorcore/zizmor/pkgs/container/zizmor (I did that in turn because it's my understanding that Docker version tags are conventionally not prefixed with I guess I'm not opposed to allowing |
I think initially it was because I thought that renovate would provide the version with the However, for the minimal change needed to support the |
Oh, can Renovate update these kinds of
Agreed; I'll do a full review later today 🙂 |
I thought it could, but it can't without me refactoring my initial code snippet. I added up with this: env:
# renovate: datasource=github-releases depName=zizmor packageName=zizmorcore/zizmor
ZIZMOR_VERSION: '1.11.0'
# then later...
- name: Lint workflows with zizmor
uses: zizmorcore/zizmor-action@f52a838cfabf134edcbaa7c8b3677dde20045018 # v0.1.1
with:
persona: pedantic
version: ${{ env.ZIZMOR_VERSION }} It leverages the |
Gotcha. TIL about that feature of Renovate as well. |
Thanks @martincostello! |
Allow the
version
input to be prefixed withv
.The README states that the version can be prefixed with
v
:zizmor-action/README.md
Lines 196 to 200 in c17832b
However, this doesn't actually work:
Fixed by allowing an optional
v
at the start of the regex and then trimming it off the value before use.