+
Skip to content

experiment with removing uv #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

experiment with removing uv #16

wants to merge 13 commits into from

Conversation

woodruffw
Copy link
Member

No description provided.

Signed-off-by: William Woodruff <william@yossarian.net>
@woodruffw woodruffw self-assigned this May 21, 2025
woodruffw added 12 commits May 20, 2025 23:19
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
@woodruffw
Copy link
Member Author

This "works," but at no small cost:

  1. Using the half-official binaries that zizmor's CI is producing means that we have pretty narrow glibc constraints, e.g. we can't run on ubuntu-22.04 or earlier because the binaries get built against a newer glibc.
  2. It's not that much faster than just using setup-uv. Maybe a second or two faster at the absolute most, although perhaps that in turn could be improved with caching.
  3. Windows is broken for unclear reasons.

(1) and (3) are annoying but not deal breakers, since this action will definitely have a "happy path" for newer runners and doesn't really need to support Windows runners (since they're significantly slower anyways). But (2) might be a deal breaker if I can't bring the performance up.

@woodruffw
Copy link
Member Author

This was a good experiment, but the lack of an immediate perf boost + additional maintenance overhead makes it not super appealing in the short term. I'm going to experiment with #19 as another alternative approach here.

@woodruffw woodruffw closed this May 28, 2025
@woodruffw woodruffw deleted the ww/no-uv branch May 28, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载