feat: better error messages for invalid inputs #956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #952. Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
woodruffw
commented
Jun 19, 2025
Comment on lines
+340
to
+352
| /// Wraps a `de::Error::custom` call to log the same error as | ||
| /// a `tracing::error!` event. | ||
| /// | ||
| /// This is useful when doing custom deserialization within untagged | ||
| /// enum variants, since serde loses track of the original error. | ||
| pub(crate) fn custom_error<'de, D>(msg: impl Display) -> D::Error | ||
| where | ||
| D: Deserializer<'de>, | ||
| { | ||
| let msg = msg.to_string(); | ||
| tracing::error!(msg); | ||
| de::Error::custom(msg) | ||
| } |
There was a problem hiding this comment.
NB: This is a pretty nasty hack -- I'd really prefer not to plumb tracing events down to this level, but serde swallows the Error::custom message itself when parsing untagged enum variants. So this is probably the shortest/simplest path towards surfacing this for debugging/diagnostics purposes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error in #952 now looks like this:
Closes #952.