Make layer's generated code deterministic #8914
Conversation
|
|
| val memoList: List[(LayerExpr, LayerExpr)] = | ||
| tree.toList.map { node => | ||
| val freshName = c.freshName("layer") | ||
| val termName = TermName(freshName) | ||
| node -> c.Expr(q"$termName") | ||
| }.toMap | ||
| } |
There was a problem hiding this comment.
Should we do a .distinct after the toList just to make sure we don't have duplicates or no need?
There was a problem hiding this comment.
LayerTree#toList still does a fold into a Set (a LinkedHashSet this time, to keep an order), thus producing a distinct output, so no need for an explicit call to .distinct
|
@reimai before I approve, do the Scala 3 macros need to be changed as well? |
This fix covers scala 3 version of zio, as it reuses the same LayerTree class with updated toList method. My local test for scala3 compiles to the exact same classfiles after the fix. |
|
@kyri-petrou Release, please, new version with these changes. |
Code generated by ZLayer's macros' is slightly different between compilations, the order of definitions and layer variable's names keep changing.
We're using bazel as a build tool and it's important for build to produce an exact same file for the same input, otherwise it's dependent targets are re-evaluated.