+
Skip to content

Do not delete zero-copy locks by default #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Do not delete zero-copy locks by default #391

wants to merge 1 commit into from

Conversation

kirillgarbar
Copy link
Contributor

@kirillgarbar kirillgarbar commented Sep 11, 2025 •
edited by sourcery-ai bot
Loading

Summary by Sourcery

Make zero-copy lock deletion opt-in by adding a flag and conditionally running the cleanup only when requested

Enhancements:

  • Add --delete-zero-copy-locks option to clickhouse-hosts command
  • Add --delete-zero-copy-locks option to remove-hosts-from-table command
  • Guard delete_zero_copy_locks calls behind the new flag so locks aren’t removed by default

@sourcery-ai Sourcery AI
Copy link
Contributor

sourcery-ai bot commented Sep 11, 2025 •
edited
Loading

Reviewer's Guide

This PR refactors two Zookeeper-related CLI commands to make zero-copy lock deletion opt-in by adding a new flag and guarding the existing deletion logic with it.

Sequence diagram for guarded zero-copy lock deletion in clickhouse_hosts_command

sequenceDiagram
    actor User
    participant CLI
    participant "delete_zero_copy_locks()"
    User->>CLI: Run clickhouse_hosts_command with/without --delete-zero-copy-locks
    CLI->>CLI: Check if delete_locks flag is set
    alt delete_locks is True
        CLI->>"delete_zero_copy_locks()": Delete locks for each host
    else delete_locks is False
        CLI->>CLI: Skip zero-copy lock deletion
    end
Loading

Sequence diagram for guarded zero-copy lock deletion in remove_hosts_from_table

sequenceDiagram
    actor User
    participant CLI
    participant "delete_zero_copy_locks()"
    User->>CLI: Run remove_hosts_from_table with/without --delete-zero-copy-locks
    CLI->>CLI: Check if delete_locks flag is set
    alt delete_locks is True
        CLI->>"delete_zero_copy_locks()": Delete locks for each host
    else delete_locks is False
        CLI->>CLI: Skip zero-copy lock deletion
    end
Loading

File-Level Changes

Change Details Files
Introduce an optional --delete-zero-copy-locks flag
  • Add @option decorator for --delete-zero-copy-locks to both clickhouse_hosts_command and remove_hosts_from_table
  • Extend both function signatures with a delete_locks boolean parameter
 ch_tools/chadmin/cli/zookeeper_group.py
Make zero-copy lock deletion conditional on the new flag
  • Wrap delete_zero_copy_locks calls inside if delete_locks: blocks in both commands
 ch_tools/chadmin/cli/zookeeper_group.py
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Sep 11, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kirillgarbar
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载