+
Skip to content

More robust handling of socket disconnection mid-game – give players up to 30 sec to reconnect before forfeiting #1749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 20, 2023
Merged

More robust handling of socket disconnection mid-game – give players up to 30 sec to reconnect before forfeiting #1749

merged 12 commits into from
Apr 20, 2023

Conversation

AlexNisnevich
Copy link
Member

@AlexNisnevich AlexNisnevich commented Apr 11, 2023 •
edited
Loading

close #1746, close #1747, close #1748, close #1750, close #1751, close #1752, close #1753, close #1754

@AlexNisnevich AlexNisnevich merged commit 8ab8bc7 into main Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacobnisnevich jacobnisnevich Awaiting requested review from jacobnisnevich

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Automatically rejoin a game you have previously left (if it is still active) when returning to the /play page Give players consistent multiplayer IDs based on their IP + browser signature (to facilitate game re-joining, etc) Gracefully handle a player disconnecting and reconnecting to a game within a short window, on the server level Don't send "X has entered the lobby" messages when the player in question is already in a game (that is, they just disconnected+reconnected to the socket connection while in-game) Disconnecting+reconnecting to websocket connection causes the player to forfeit the game (the ws:CONNECTING message returns the player to the lobby)
Players leaving a game due to forfeit still see the game listed in the lobby Console errors due to unmounting <Waiting> component when joining games Upon a player entering the lobby, connect them back into any active game that they are still in

1 participant

@AlexNisnevich
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载