-
Notifications
You must be signed in to change notification settings - Fork 5
Support for card rarities in Set Draft mode + many bug fixes (involving set/deck editing, flavor text, etc) #1666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
const numCommonGroups = totalNumGroups - numUncommonGroups - numRareGroups; | ||
|
||
return shuffle([ | ||
...new Array(numRareGroups).fill('rare'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: constants for rare
, uncommon
, common
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better yet a const enum
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eh, the typechecker already kind of makes sure things are fine here
Rarities for cards in sets (close #1532):
Bug fixes unrelated to card rarities: