Convert socket.js to TypeScript #730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanftw
approved these changes
Jun 30, 2018
| // If fallbackToClientID is true, falls back to the client ID if there is no | ||
| // username set, otherwise returns null. | ||
| getClientUsername = (clientID: m.ClientID, fallbackToClientID = true): string => ( | ||
| getClientUsername = (clientID: m.ClientID, fallbackToClientID = true): string | null => ( |
There was a problem hiding this comment.
What do you think about using some implementation of optional to clean up the typing?
like: https://www.npmjs.com/package/optional-js
There was a problem hiding this comment.
Ooh, that's a good idea. I'll merge as-is for now since this would be a pretty major change, but I made a ticket – #733.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.