Replace CollectionFS with meteor-file-collection #875
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avatars & import are not yet functional. Using missing features result in console warnings with the prefix [re-attach].
|
Thanks! I think this can be merged when it automatically detects CollectionFS attachments and converts them to meteor-file-collection. On some platforms like Sandstorm where Wekan code is signed and read-only, it's not possible to run separate migration scripts. |
|
Can other developers join and contribute to this PR? If yes, how? |
|
Sorry, looks like I don't have the time I expected to have to work on Wekan stuff. The "Allow edits from maintainers" tag is set on this, so at least @xet7 should have push rights to the source branch in our fork. I'm also ok with someone else starting a new PR based on this, using their own fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library currently used by Wekan for attachments (CollectionFS) is not very actively maintained, having been deprecated for most of 2016. It's also somewhat extensive in its feature set, of which Wekan uses only a fraction but is burdened by bugs resulting from said complexity. So I'm here proposing to replace it with meteor-file-collection, which has mostly the same interfaces as CollectionFS and also uses GridFS for storage.
In addition to being simpler and more secure, the built-in resumable.js integration will enable simultaneous upload of multiple files, as well as drag-and-drop for attachment upload.
The particular CollectionFS bug that I hit that prompted its replacement was its inability to deal well with local uploads, a part of a custom import job that I needed to get to work.
This is a work-in-progress, so should not be merged until the following are all done:
At the moment, using missing features result in console warnings with the prefix
[re-attach].In addition to the above, other issues that would probably get resolved by this include: #142, #386, #544, #698, #784, Meteor-Community-Packages/Meteor-CollectionFS#449.
This change is