+
Skip to content

Conversation

Kidswiss
Copy link
Collaborator

@Kidswiss Kidswiss commented Aug 25, 2023

Summary

  • Dummy bucket CRD
  • Pre-wired webhook setup
  • Generating examples and crossplane package
  • Docs
  • Pre wired e2e-test

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

@Kidswiss Kidswiss added the enhancement New feature or request label Aug 25, 2023
@Kidswiss Kidswiss force-pushed the bootstrap branch 2 times, most recently from d4ce118 to a5ed3f4 Compare August 25, 2023 07:58
Copy link
Contributor

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


webhook-debug: $(webhook_cert) ## Creates certificates, patches the webhook registrations and applies everything to the given kube cluster
webhook-debug:
#
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this target needed at this point?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet, but I'm pretty sure the bucket will have at least one webhook. So i just wanted to make sure everything is prepared.

@Kidswiss Kidswiss merged commit 8869c40 into master Aug 25, 2023
rossigee pushed a commit to rossigee/provider-minio that referenced this pull request Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载