+
Skip to content

[plugin-rest-api] Post executed requests in a curl syntax in allure attachments #4724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[plugin-rest-api] Post executed requests in a curl syntax in allure attachments #4724

wants to merge 1 commit into from

Conversation

abudevich
Copy link
Contributor

@abudevich abudevich commented Jan 11, 2024 •
edited by valfirst
Loading

Closes #328

@abudevich abudevich requested a review from a team as a code owner January 11, 2024 16:24
@codecov Codecov
Copy link

codecov bot commented Jan 11, 2024 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.68%. Comparing base (072bddb) to head (dd7939d).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #4724   +/-   ##
=========================================
  Coverage     97.67%   97.68%           
- Complexity     7315     7330   +15     
=========================================
  Files          1006     1007    +1     
  Lines         21221    21273   +52     
  Branches       1387     1392    +5     
=========================================
+ Hits          20728    20780   +52     
  Misses          376      376           
  Partials        117      117

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@valfirst valfirst changed the title [plugin-rest-api] Post executed requests in a curl syntax in allure a… [plugin-rest-api] Post executed requests in a curl syntax in allure attachments Jan 12, 2024
valfirst
valfirst requested changes Jan 12, 2024
View reviewed changes
valfirst
valfirst requested changes Jan 15, 2024
View reviewed changes
valfirst
valfirst requested changes Jan 16, 2024
View reviewed changes
@abudevich abudevich force-pushed the 328-curl branch 2 times, most recently from 38834ca to 14c97eb Compare January 17, 2024 08:31
@abudevich abudevich requested a review from valfirst January 17, 2024 08:31
@abudevich abudevich requested a review from valfirst January 18, 2024 14:33
valfirst
valfirst requested changes Jan 18, 2024
View reviewed changes
@abudevich abudevich force-pushed the 328-curl branch 2 times, most recently from d3176fe to 48fbdf2 Compare January 19, 2024 08:57
@abudevich abudevich requested a review from valfirst January 19, 2024 09:07
valfirst
valfirst requested changes Jan 23, 2024
View reviewed changes
vividus-plugin-rest-api/src/main/java/org/vividus/http/PublishingAttachmentInterceptor.java Outdated
Optional.ofNullable(ContentType.parseLenient(entity.getContentType()))
.orElse(ContentType.DEFAULT_TEXT).getMimeType()
);
isBinaryContent = entity instanceof ByteArrayEntity;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not always true:

  • if mimetype is textual, then it's not binary (even if it's of ByteArrayEntity)
  • if mimetype is not textual or not present, then we assume the content is binary, if it's not of StringEntity

@abudevich abudevich force-pushed the 328-curl branch 3 times, most recently from 8ce42c5 to 11b46ec Compare February 5, 2024 08:05
@abudevich abudevich force-pushed the 328-curl branch 2 times, most recently from ae6aa0f to 11fe6d8 Compare August 5, 2025 13:58
@abudevich abudevich force-pushed the 328-curl branch 4 times, most recently from 68a2327 to ab537e9 Compare August 25, 2025 13:47
@abudevich abudevich force-pushed the 328-curl branch 2 times, most recently from 812a3f1 to 8c00abd Compare August 26, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valfirst valfirst valfirst requested changes

@ikalinin1 ikalinin1 Awaiting requested review from ikalinin1 ikalinin1 is a code owner automatically assigned from vividus-framework/maintainers

@draker94 draker94 Awaiting requested review from draker94 draker94 is a code owner automatically assigned from vividus-framework/maintainers

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Http Client] Post executed requests in a curl syntax
2 participants
@abudevich @valfirst
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载