fix: use current UUID type #2399
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We'll have to go through a deprecation phase here to avoid the immediate breakage. I'd suggest to add two new definitions ( Finally, in the next major release, |
|
@s-ludwig I see, make sense deprecating first, I'll stay on my fork for now. It's such a nice design in that it can take the base structs and automatically map the members from and to BSON without annotations. Thanks for a nice library. |
|
No that was not intended, I'm experimenting on my fork for needs I have in my project. I'll see if I can clean it up.
6 feb. 2020 06:42:24 thaven <notifications@github.com>:
…
>
> feat(SysTime): add support to parse SysTime 17f897b [17f897b]
> feat: serialize SysTime b41b7ef [b41b7ef]
> Merge branch 'master' of github.com:tirithen/vibe.d 4adcc91 [4adcc91]
>
@tirithen [https://github.com/tirithen] I suppose you did not mean to push these commits to this PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub [#2399?email_source=notifications&email_token=AAB4AM4NIIB6CWBN32JZDATRBOPMBA5CNFSM4JZFNGR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEK6AEFY#issuecomment-582746647] , or unsubscribe [https://github.com/notifications/unsubscribe-auth/AAB4AM3V5K7RFCKAEJDRVG3RBOPMBANCNFSM4JZFNGRQ] . [https://github.com/notifications/beacon/AAB4AM3DKLBJHWK3WHEHXN3RBOPMBA5CNFSM4JZFNGR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEK6AEFY.gif]
|
std.uuid.UUID as being converted to the legacy BSON UUID type. BREAKING CHANGE: type change from BinData 0x03 to 0x04 for std.uuid.UUID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std.uuid.UUID as being converted to the legacy BSON UUID type.
BREAKING CHANGE: type change from BinData 0x03 to 0x04 for std.uuid.UUID