+
Skip to content

Conversation

mythsmith
Copy link
Contributor

Addresses #139, #137

  • Dataset label is used as PointPlotter key if none is set and the dataset is yData.
  • The key is automatically updated on yData change. If the key is deleted, it a new attempt to read the dataset label is made.
  • the dataset edit dialog now has a tabbed view: one tab for the data, one for the attributes.
    data_tab
    attr_tab
    I made an very extensible attr table because I plan to implement more feature building on Extensible Dataset Attributes #137 concept (units, hierarchy, etc).

@jeremysanders
Copy link
Collaborator

It looks a very nice feature. I'll try and review it soon...

@jeremysanders
Copy link
Collaborator

Ok - looks interesting, but there are some problems at a first glance:

  • The contour widget doesn't work any more (the self tests don't succeed). I think it is because it drops the key setting, as it uses separate keys for each level.

  • Therefore, maybe it would be better not to overwrite the key setting on the document change? Usually Veusz doesn't do self-modifying settings (except for the fit widget). You could hook into getKeyText to generate the automatic text, though I'm not sure how the user would then make the key text empty if they didn't want one.

  • I can't get the automatic key to work, if I take the sin example, set a label attribute, then add a key. Nothing seems to show.

  • Saving the sin example with the attributes breaks the saved file as SaveDataAttr is put above the ImportString command which makes the dataset. I seem to remember there's some logic to avoid this for dataset tags.

I'll look further at the code later, but thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载