Add Western Sahara holidays #3003

PPsyrius · 2025-10-13T08:39:36Z

Proposed change

Add Western Sahara holidays (with ar, en_US, es, and fr l10n support).

We've finally have support for all ISO 3166 entities 🎉

Resolves #2657 .

Type of change

New country/market holidays support (thank you!)
Supported country/market holidays update (calendar discrepancy fix, localization)
Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
Dependency update (version deprecation/pin/upgrade)
Bugfix (non-breaking change which fixes an issue)
Breaking change (a code change causing existing functionality to break)
New feature (new holidays functionality in general)

Checklist

I've read and followed the contributing guidelines.
I've run make check locally; all checks and tests passed.

coderabbitai · 2025-10-13T08:39:48Z

Summary by CodeRabbit

New Features
- Added Western Sahara holiday calendar (EH/ESH) with national and Islamic holidays.
- Added multilingual names (ar, en_US, es, fr) and optional “estimated” labels for Islamic dates.
Documentation
- Updated README: supported countries now 249; clarified ISO references and language handling; minor URL punctuation fix.
Tests
- Added comprehensive tests for Western Sahara holidays and localizations.
Chores
- Added locale translations and snapshot data for Western Sahara.

Walkthrough

Adds Western Sahara (EH/ESH): new country Holiday class with fixed and Islamic holidays, exports aliases, registers it, adds locale PO files (ar, en_US, es, fr), includes tests and snapshots, and updates README country count. No existing country logic modified.

Changes

Cohort / File(s)	Summary
Country implementation & registration `holidays/countries/western_sahara.py`, `holidays/countries/__init__.py`, `holidays/registry.py`	Added `WesternSahara` Holidays class (inherits IslamicHolidays), exported aliases `EH`/`ESH`, and registered `western_sahara` in COUNTRIES.
Locales `holidays/locale/ar/LC_MESSAGES/EH.po`, `holidays/locale/en_US/LC_MESSAGES/EH.po`, `holidays/locale/es/LC_MESSAGES/EH.po`, `holidays/locale/fr/LC_MESSAGES/EH.po`	Added PO files for Western Sahara holiday names (Arabic placeholders; en_US, es, fr translations provided).
Tests `tests/countries/test_western_sahara.py`	New test suite covering aliases, fixed-date holidays, Islamic holidays (with/without estimated), and localization checks.
Snapshots `snapshots/countries/EH_COMMON.json`	Added snapshot data for Western Sahara holidays (2000–2050) used in regression tests.
Docs `README.md`	Updated available countries count and refined country/language wording; added Western Sahara row and minor formatting edits.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Suggested reviewers

KJhellico

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title “Add Western Sahara holidays” succinctly and accurately captures the main change of the pull request by focusing on the addition of support for Western Sahara holidays, making it clear to reviewers what the core update entails.
Linked Issues Check	✅ Passed	The pull request fully implements the primary objective of issue #2657 by adding a WesternSahara holiday class, registering it, providing localization files, snapshots, and tests, thereby delivering comprehensive holiday support for Western Sahara.
Out of Scope Changes Check	✅ Passed	All modifications are focused on introducing Western Sahara holiday support, including code, localization, registry updates, snapshots, and tests, with no unrelated or out-of-scope changes detected.
Description Check	✅ Passed	The description clearly outlines the addition of Western Sahara holidays complete with localization support and references the resolved issue, directly aligning with the content of the changeset.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2025-10-13T08:41:42Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (66a5f43) to head (26477b5).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff            @@
##               dev     #3003   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          305       306    +1     
  Lines        18041     18072   +31     
  Branches      2330      2332    +2     
=========================================
+ Hits         18041     18072   +31

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

KJhellico

LGTM! 👍

arkid15r

Aaand done!
LGTM 👍

Thanks everyone for being part of this!

Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>

sonarqubecloud · 2025-10-14T21:14:00Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

coderabbitai

Actionable comments posted: 2

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 104a084 and 26477b5.

📒 Files selected for processing (1)

README.md (3 hunks)

🧰 Additional context used

🧠 Learnings (3)

📓 Common learnings

Learnt from: KJhellico
PR: vacanza/holidays#2774
File: tests/countries/test_liberia.py:15-16
Timestamp: 2025-08-08T14:37:03.045Z
Learning: When adding a new country in vacanza/holidays, also re-export it in holidays/countries/__init__.py (e.g., from .liberia import Liberia, LR, LBR) so tests and users can import from holidays.countries consistently.

Learnt from: KJhellico
PR: vacanza/holidays#2820
File: holidays/countries/__init__.py:199-203
Timestamp: 2025-08-31T19:34:20.731Z
Learning: In Saint Helena, Ascension and Tristan da Cunha holidays implementation (holidays/countries/saint_helena_ascension_and_tristan_da_cunha.py), only three classes are defined: SaintHelenaAscensionAndTristanDaCunha (main class), SH (alias), and SHN (alias). There is no HolidaysSH class, despite it being referenced in the registry.py entry.

📚 Learning: 2025-03-26T08:55:08.917Z

Learnt from: PPsyrius
PR: vacanza/holidays#2362
File: holidays/ical.py:53-80
Timestamp: 2025-03-26T08:55:08.917Z
Learning: The holidays library intentionally limits language code support to ISO 639-1 and ISO 639-2 standards (2-3 letter language codes with optional region) to maintain consistency with other modules like `common_holidays` and `financial_holidays`, rather than implementing full RFC 5646 compliance.

Applied to files:

README.md

📚 Learning: 2025-06-09T19:39:38.818Z

Learnt from: KJhellico
PR: vacanza/holidays#2601
File: README.md:108-108
Timestamp: 2025-06-09T19:39:38.818Z
Learning: The correct way to count supported countries in the holidays library is by counting unique country module files in holidays/countries/ (excluding __init__.py) or by counting entries in the COUNTRIES registry, not by counting individual class definitions which include alias classes.

Applied to files:

README.md

🪛 LanguageTool

README.md

[grammar] ~60-~60: Use correct spacing
Context: ... Docs](https://holidays.readthedocs.io). ## Quick Start ``` python from datetime im...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

[grammar] ~103-~103: There might be a mistake here.
Context: ...rg/wiki/List_of_ISO_3166_country_codes), the same used for domain names, and for ...

(QB_NEW_EN)

[grammar] ~104-~104: There might be a mistake here.
Context: ...e same used for domain names, and for a subdivision its [ISO 3166-2 code](https://en.wikipe...

(QB_NEW_EN_OTHER)

[grammar] ~104-~104: There might be a mistake here.
Context: ...s, and for a subdivision its [ISO 3166-2 code](https://en.wikipedia.org/wiki/ISO_...

(QB_NEW_EN)

⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Test Python 3.14 on windows-latest

🔇 Additional comments (1)

README.md (1)
102-114: Verify country count and apply grammar tweak
Confirm the actual count in COUNTRIES via:
grep -E '^\s*"[a-z0-9_ ]+"\s*:' holidays/registry.py | wc -l
If it’s not 249, update the README.
Change “the same used” to “the same as used” and add a comma after “subdivision”.
-The standard way to refer to a country is by using its [ISO 3166-1 alpha-2 code](…),
-the same used for domain names, and for a subdivision its [ISO 3166-2 code](…).
+The standard way to refer to a country is by using its [ISO 3166-1 alpha-2 code](…),
+the same as used for domain names, and for a subdivision, its [ISO 3166-2 code](…).

README.md

Add Western Sahara holidays

5b993c1

PPsyrius requested review from KJhellico and arkid15r as code owners October 13, 2025 08:39

github-actions bot added l10n snapshot test labels Oct 13, 2025

Merge branch 'dev' into western_sahara

9c83436

KJhellico previously approved these changes Oct 14, 2025

View reviewed changes

Update README.md

104a084

arkid15r dismissed KJhellico’s stale review via 104a084 October 14, 2025 20:51

arkid15r previously approved these changes Oct 14, 2025

View reviewed changes

arkid15r added this pull request to the merge queue Oct 14, 2025

arkid15r removed this pull request from the merge queue due to a manual request Oct 14, 2025

Include all core team members into this milestone commit

26477b5

Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>

arkid15r dismissed their stale review via 26477b5 October 14, 2025 21:12

arkid15r enabled auto-merge October 14, 2025 21:12

arkid15r approved these changes Oct 14, 2025

View reviewed changes

coderabbitai bot reviewed Oct 14, 2025

View reviewed changes

README.md Show resolved Hide resolved

README.md Show resolved Hide resolved

arkid15r added this pull request to the merge queue Oct 14, 2025

Merged via the queue into vacanza:dev with commit 0f97ba3 Oct 14, 2025
36 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Add Western Sahara holidays #3003

Add Western Sahara holidays #3003

PPsyrius commented Oct 13, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Oct 13, 2025 •

edited

Loading

Uh oh!

codecov bot commented Oct 13, 2025 •

edited

Loading

Uh oh!

KJhellico left a comment

Uh oh!

arkid15r left a comment

Uh oh!

Uh oh!

sonarqubecloud bot commented Oct 14, 2025

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Add Western Sahara holidays #3003

Add Western Sahara holidays #3003

Conversation

PPsyrius commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed change

Type of change

Checklist

Uh oh!

coderabbitai bot commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Pre-merge checks and finishing touches

Uh oh!

codecov bot commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

KJhellico left a comment

Choose a reason for hiding this comment

Uh oh!

arkid15r left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonarqubecloud bot commented Oct 14, 2025

Quality Gate passed

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

PPsyrius commented Oct 13, 2025 •

edited

Loading

coderabbitai bot commented Oct 13, 2025 •

edited

Loading

codecov bot commented Oct 13, 2025 •

edited

Loading