+
Skip to content

Introduce HolidayBase::_is_weekday method #2999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 11, 2025
Merged

Introduce HolidayBase::_is_weekday method #2999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b29073
Introduce `HolidayBase::_is_weekday` method
PPsyrius Oct 9, 2025
9751ec7
Merge branch 'dev' into _is_weekday
PPsyrius Oct 10, 2025
77d4b24
Update code
arkid15r Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion holidays/holiday_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -865,7 +865,14 @@ def _is_saturday(self, *args) -> bool:
def _is_sunday(self, *args) -> bool:
return self._check_weekday(SUN, *args)

def _is_weekend(self, *args):
def _is_weekday(self, *args) -> bool:
"""
Returns True if date's week day is not a weekend day.
Returns False otherwise.
"""
return not self._is_weekend(*args)

def _is_weekend(self, *args) -> bool:
"""
Returns True if date's week day is a weekend day.
Returns False otherwise.
Expand Down
8 changes: 8 additions & 0 deletions tests/test_holiday_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,23 +567,31 @@ def test_is_weekend(self):
self.hb.weekend = {MON, TUE}
for dt in dts:
self.assertTrue(self.hb._is_weekend(dt))
self.assertFalse(self.hb._is_weekday(dt))

self.hb.weekend = {}
for dt in dts:
self.assertFalse(self.hb._is_weekend(dt))
self.assertTrue(self.hb._is_weekday(dt))

self.hb.weekend = {SAT, SUN}
for dt in (date(2022, 10, 1), date(2022, 10, 2)):
self.assertTrue(self.hb._is_weekend(dt))
self.assertFalse(self.hb._is_weekday(dt))
for dt in ((OCT, 1), (OCT, 2)):
self.assertTrue(self.hb._is_weekend(dt))
self.assertTrue(self.hb._is_weekend(*dt))
self.assertFalse(self.hb._is_weekday(dt))
self.assertFalse(self.hb._is_weekday(*dt))

for dt in (date(2022, 10, 3), date(2022, 10, 4)):
self.assertFalse(self.hb._is_weekend(dt))
self.assertTrue(self.hb._is_weekday(dt))
for dt in ((OCT, 3), (OCT, 4)):
self.assertFalse(self.hb._is_weekend(dt))
self.assertFalse(self.hb._is_weekend(*dt))
self.assertTrue(self.hb._is_weekday(dt))
self.assertTrue(self.hb._is_weekday(*dt))


class TestHolidaySum(unittest.TestCase):
Expand Down
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载