+
Skip to content

Update the United States holidays: add Father's Day and Mother's Day for UNOFFICIAL category #2975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2025
Merged

Update the United States holidays: add Father's Day and Mother's Day for UNOFFICIAL category #2975

merged 1 commit into from
Oct 3, 2025

Conversation

PPsyrius
Copy link
Collaborator

@PPsyrius PPsyrius commented Oct 2, 2025 •
edited
Loading

Proposed change

Add the United States' "Father's Day" (3rd Sunday of June) and "Mother's Day" (2nd Sunday of May) under the UNOFFICIAL category alongside its test cases (perhaps this should've been WORKDAY category instead? Let me know)

Resolves #2923 .

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 2, 2025 •
edited
Loading

Summary by CodeRabbit

  • New Features
    • Added unofficial observance of Mother’s Day (2nd Sunday of May, from 1914) and Father’s Day (3rd Sunday of June, from 1972) across the US and territories.
  • Data Updates
    • Expanded holiday datasets with Mother’s Day and Father’s Day dates; overlapping dates now show combined labels with Juneteenth where applicable.
  • Localization
    • Added translatable strings for “Mother’s Day” and “Father’s Day” in English; provided Thai translations and refreshed translation metadata.

Walkthrough

Adds Mother's Day (2nd Sunday of May, from 1914) and Father's Day (3rd Sunday of June, from 1972) to US holidays logic. Updates en_US and th translations. Regenerates snapshot JSONs across US common, territories, and state files to include new entries and combined labels with Juneteenth where dates coincide.

Changes

Cohort / File(s) Summary of changes
US holiday logic
holidays/countries/united_states.py		 Add conditional population for Mother's Day (>=1914) and Father's Day (>=1972) using existing nth-Sunday helpers; no API/signature changes.
Localization (en, th)
holidays/locale/en_US/LC_MESSAGES/US.po, holidays/locale/th/LC_MESSAGES/US.po		 Update PO metadata; add msgid entries for "Mother's Day" and "Father's Day" (en with empty msgstr, th with translations).
Snapshots — COMMON datasets
snapshots/countries/AS_COMMON.json, .../GU_COMMON.json, .../MP_COMMON.json, .../PR_COMMON.json, .../UM_COMMON.json, .../US_COMMON.json		 Data additions for Mother's Day across years; add Father’s Day where applicable; update overlapping dates to combined labels (e.g., "Father's Day; Juneteenth National Independence Day"); no structural changes.
Snapshots — US states/territories
snapshots/countries/US_*.json (e.g., US_AK.json, US_AL.json, US_AR.json, US_AS.json, US_AZ.json, US_CA.json, US_CO.json, US_CT.json, US_DC.json, US_DE.json, US_FL.json, US_GA.json, US_GU.json, US_HI.json)		 Insert annual Mother's Day entries; add Father’s Day entries (>=1972); update select years where Father’s Day coincides with Juneteenth to combined labels; data-only changes.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Suggested labels

snapshot, test, l10n

Suggested reviewers

  • arkid15r
  • KJhellico

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Title Check ✅ Passed The title clearly states the main change of the pull request by indicating that both Father’s Day and Mother’s Day are being added to the United States holidays under the UNOFFICIAL category, matching the content of the changeset without extraneous details or file listings.
Linked Issues Check ✅ Passed The implementation adds Mother’s Day for years ≥ 1914 and Father’s Day for years ≥ 1972 exactly as specified in issue #2923, including appropriate year gating and integration with existing holiday logic, fulfilling the linked issue’s requirements.
Out of Scope Changes Check ✅ Passed All changes—updates to the country logic, locale files, and regenerated snapshots—directly correspond to adding Mother’s Day and Father’s Day and the resulting combined entries with existing holidays; there are no unrelated or out-of-scope modifications.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Description Check ✅ Passed The pull request description succinctly explains that it adds Mother’s Day and Father’s Day under the UNOFFICIAL category with accompanying tests and links to issue #2923, which aligns directly with the code, localization, and snapshot changes in the PR.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 2, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov Codecov
Copy link

codecov bot commented Oct 2, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (a4c369e) to head (e55bf06).
⚠️ Report is 2 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #2975   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          301       301           
  Lines        17962     17966    +4     
  Branches      2319      2321    +2     
=========================================
+ Hits         17962     17966    +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

KJhellico
KJhellico approved these changes Oct 2, 2025
View reviewed changes
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. UNOFFICIAL category is exactly suitable for such kind of holidays. 👍

@arkid15r arkid15r added this pull request to the merge queue Oct 2, 2025
Merged via the queue into vacanza:dev with commit 4e783ce Oct 3, 2025
36 checks passed
@PPsyrius PPsyrius deleted the usa_mothers_day_and_fathers_day branch October 3, 2025 07:11
@arkid15r arkid15r mentioned this pull request Oct 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KJhellico KJhellico KJhellico approved these changes

@arkid15r arkid15r Awaiting requested review from arkid15r arkid15r is a code owner

Assignees

No one assigned

Labels

l10n snapshot test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update US holidays: add Mother's Day, Father's Day

3 participants

@PPsyrius @KJhellico @arkid15r
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载