-
-
Notifications
You must be signed in to change notification settings - Fork 556
Update Afghanistan holidays: 2025 exact Islamic holidays observances #2932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary by CodeRabbit
WalkthroughExtends Afghanistan Islamic holiday confirmed year ranges to 2025 and adds 2025 specific dates. Updates an archived documentation link in the Afghanistan class docstring. Refreshes AF snapshot data to remove “estimated” and adjust 2025 dates. Updates tests to include 2025 dates and renames one test method. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (3)
🧰 Additional context used🧠 Learnings (20)📓 Common learnings
📚 Learning: 2025-08-21T06:52:25.511Z
Applied to files:
📚 Learning: 2025-03-29T15:15:05.919Z
Applied to files:
📚 Learning: 2025-03-19T16:54:58.657Z
Applied to files:
📚 Learning: 2025-05-06T13:01:22.693Z
Applied to files:
📚 Learning: 2025-04-13T20:41:56.613Z
Applied to files:
📚 Learning: 2025-04-05T04:47:27.213Z
Applied to files:
📚 Learning: 2025-04-05T06:49:06.217Z
Applied to files:
📚 Learning: 2025-04-04T10:52:41.546Z
Applied to files:
📚 Learning: 2025-05-06T21:07:11.577Z
Applied to files:
📚 Learning: 2025-09-14T16:05:55.181Z
Applied to files:
📚 Learning: 2025-09-14T04:41:10.130Z
Applied to files:
📚 Learning: 2025-04-04T10:52:41.546Z
Applied to files:
📚 Learning: 2025-07-24T15:21:31.632Z
Applied to files:
📚 Learning: 2025-09-14T16:03:13.496Z
Applied to files:
📚 Learning: 2025-09-03T14:05:10.592Z
Applied to files:
📚 Learning: 2025-09-14T16:14:44.954Z
Applied to files:
📚 Learning: 2025-09-14T16:14:44.954Z
Applied to files:
📚 Learning: 2025-06-25T10:36:39.909Z
Applied to files:
📚 Learning: 2025-06-25T10:36:39.103Z
Applied to files:
🧬 Code graph analysis (1)tests/countries/test_afghanistan.py (1)
🔇 Additional comments (12)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Ruff (0.12.2)holidays/countries/afghanistan.py�[1;31mruff failed�[0m tests/countries/test_afghanistan.py�[1;31mruff failed�[0m Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #2932 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 296 296
Lines 17593 17593
Branches 2270 2270
=========================================
Hits 17593 17593 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed change
Add Afghanistan's 2025 exact Islamic holidays observances.
This is part of the non-test case changes decoupling from #2881
Type of change
holidays
functionality in general)Checklist
make check
locally; all checks and tests passed.