Update Egypt holidays: update remaining .po files changes #2748

PPsyrius · 2025-07-24T09:01:13Z

Proposed change

Update remaining .po files changes for Egypt holidays (I spot these by chance while running make check for #2746 )

Type of change

New country/market holidays support (thank you!)
Supported country/market holidays update (calendar discrepancy fix, localization)
Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
Dependency update (version deprecation/pin/upgrade)
Bugfix (non-breaking change which fixes an issue)
Breaking change (a code change causing existing functionality to break)
New feature (new holidays functionality in general)

Checklist

I've read and followed the contributing guidelines.
I've run make check locally; all checks and tests passed.

coderabbitai · 2025-07-24T09:01:20Z

Summary by CodeRabbit

Refactor
- Reordered the comment and translation entries for "Spring Festival" in Arabic, English, and French locale files. No changes were made to the actual translation content.

Walkthrough

The ordering of comment and translation entries for "Spring Festival" and "Sinai Liberation Day" was adjusted in the Egyptian holiday localization files for Arabic, English, and French. No translation content or message IDs were changed; only the sequence of entries and their comments was updated.

Changes

Files	Change Summary
holidays/locale/ar_EG/LC_MESSAGES/EG.po, holidays/locale/en_US/LC_MESSAGES/EG.po, holidays/locale/fr/LC_MESSAGES/EG.po	Reordered the comment and translation entry for "Spring Festival" to appear after "Sinai Liberation Day" without altering any translation content.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

l10n

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6e08faf and 2ec7a04.

📒 Files selected for processing (3)

holidays/locale/ar_EG/LC_MESSAGES/EG.po (1 hunks)
holidays/locale/en_US/LC_MESSAGES/EG.po (1 hunks)
holidays/locale/fr/LC_MESSAGES/EG.po (1 hunks)

⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

GitHub Check: Test build on windows-latest
GitHub Check: Test build on ubuntu-latest

🔇 Additional comments (3)

holidays/locale/en_US/LC_MESSAGES/EG.po (1)

61-64: Order tweak looks fine.

Just a re-ordering of the Spring Festival block. No content change, no risk. 👍

holidays/locale/ar_EG/LC_MESSAGES/EG.po (1)

61-64: Re-ordering approved.

Entry moved but untouched—all good. 🚀

holidays/locale/fr/LC_MESSAGES/EG.po (1)

61-64: Looks good.

Same safe shuffle here; nothing else to flag. ✅

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

sonarqubecloud · 2025-07-24T09:02:00Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

codecov · 2025-07-24T09:02:47Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6e08faf) to head (2ec7a04).
Report is 1 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff            @@
##               dev     #2748   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          271       271           
  Lines        16199     16199           
  Branches      2190      2190           
=========================================
  Hits         16199     16199

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

KJhellico

Thank you for catching this! LGTM.

Update Egypt holidays: update remaining .po files changes

2ec7a04

PPsyrius requested review from KJhellico and arkid15r as code owners July 24, 2025 09:01

github-actions bot added the l10n label Jul 24, 2025

KJhellico approved these changes Jul 24, 2025

View reviewed changes

KJhellico enabled auto-merge July 24, 2025 09:04

KJhellico added this pull request to the merge queue Jul 24, 2025

Merged via the queue into vacanza:dev with commit 305b3d6 Jul 24, 2025
33 checks passed

PPsyrius deleted the egy_l10n branch July 24, 2025 13:36

KJhellico mentioned this pull request Aug 4, 2025

v0.78 #2779

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Update Egypt holidays: update remaining .po files changes #2748

Update Egypt holidays: update remaining .po files changes #2748

Uh oh!

PPsyrius commented Jul 24, 2025

Uh oh!

coderabbitai bot commented Jul 24, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

sonarqubecloud bot commented Jul 24, 2025

Uh oh!

codecov bot commented Jul 24, 2025 •

edited

Loading

Uh oh!

KJhellico left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Update Egypt holidays: update remaining .po files changes #2748

Update Egypt holidays: update remaining .po files changes #2748

Uh oh!

Conversation

PPsyrius commented Jul 24, 2025

Proposed change

Type of change

Checklist

Uh oh!

coderabbitai bot commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Walkthrough

Changes

Estimated code review effort

Suggested labels

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

sonarqubecloud bot commented Jul 24, 2025

Quality Gate passed

Uh oh!

codecov bot commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

KJhellico left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai bot commented Jul 24, 2025 •

edited

Loading

codecov bot commented Jul 24, 2025 •

edited

Loading