-
-
Notifications
You must be signed in to change notification settings - Fork 541
Show test coverage details by default #2686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary by CodeRabbit
WalkthroughThe coverage reporting workflow was streamlined by removing separate coverage commands and targets from the Makefile, make.cmd, and documentation. Now, running tests directly provides detailed coverage output, including missing lines, eliminating the need for a standalone coverage step. Changes
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (3)
🧰 Additional context used🧠 Learnings (4)📓 Common learnings
CONTRIBUTING.md (2)
Makefile (3)
make.cmd (1)
⏰ Context from checks skipped due to timeout of 300000ms (16)
🔇 Additional comments (3)
✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2686 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 251 251
Lines 15315 15315
Branches 2095 2095
=========================================
Hits 15315 15315 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Proposed change
Retire
make coverage
, extendmake test
to show uncovered lines by default.Type of change
holidays
functionality in general)Checklist
make check
, all checks and tests are green