Update pytest configuration #2640

KJhellico · 2025-06-17T10:23:32Z

Proposed change

Add testpaths option to speed up tests collection.

Type of change

New country/market holidays support (thank you!)
Supported country/market holidays update (calendar discrepancy fix, localization)
Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
Dependency update (version deprecation/pin/upgrade)
Bugfix (non-breaking change which fixes an issue)
Breaking change (a code change causing existing functionality to break)
New feature (new holidays functionality in general)

Checklist

I've followed the contributing guidelines
I've successfully run make check, all checks and tests are green

coderabbitai · 2025-06-17T10:23:38Z

Summary by CodeRabbit

Chores
- Updated test configuration to specify the directory for test discovery.

Summary by CodeRabbit

Chores
- Updated test configuration to specify the directory where tests are located.

Walkthrough

The pytest configuration in the pyproject.toml file was updated to specify tests as the directory for test discovery using the testpaths option. No other changes were made.

Changes

File(s)	Change Summary
pyproject.toml	Added `testpaths = ["tests"]` under pytest config

Suggested labels

test

Suggested reviewers

arkid15r
PPsyrius

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6fdbdb0 and 2ff642a.

📒 Files selected for processing (1)

pyproject.toml (1 hunks)

⏰ Context from checks skipped due to timeout of 300000ms (1)

GitHub Check: Run pre-commit

🔇 Additional comments (1)

pyproject.toml (1)

86-86: Limit pytest discovery to the tests directory

By specifying testpaths = ["tests"], pytest will only scan the tests folder, reducing collection time. This aligns with best practices for faster test runs.

✨ Finishing Touches

🧪 Generate Unit Tests

Create PR with Unit Tests
Commit Unit Tests in branch upd-pytest-config
Post Copyable Unit Tests in Comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai auto-generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2025-06-17T10:25:21Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ded1d37) to head (2ff642a).
Report is 1 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff            @@
##               dev     #2640   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          235       235           
  Lines        14869     14869           
  Branches      2063      2063           
=========================================
  Hits         14869     14869

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

PPsyrius

LGTM 🛠️

arkid15r

LGTM

pyproject.toml

Co-authored-by: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com> Signed-off-by: ~Jhellico <KJhellico@users.noreply.github.com>

sonarqubecloud · 2025-06-17T16:34:30Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Update pytest config

6fdbdb0

KJhellico requested review from PPsyrius and arkid15r as code owners June 17, 2025 10:23

PPsyrius previously approved these changes Jun 17, 2025

View reviewed changes

arkid15r previously approved these changes Jun 17, 2025

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

PR suggestion

2ff642a

Co-authored-by: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com> Signed-off-by: ~Jhellico <KJhellico@users.noreply.github.com>

KJhellico dismissed stale reviews from arkid15r and PPsyrius via 2ff642a June 17, 2025 16:32

PPsyrius approved these changes Jun 17, 2025

View reviewed changes

arkid15r added this pull request to the merge queue Jun 17, 2025

Merged via the queue into vacanza:dev with commit 53942bc Jun 17, 2025
33 checks passed

KJhellico deleted the upd-pytest-config branch June 17, 2025 18:41

KJhellico mentioned this pull request Jul 7, 2025

v0.76 #2705

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Update pytest configuration #2640

Update pytest configuration #2640

Uh oh!

KJhellico commented Jun 17, 2025

Uh oh!

coderabbitai bot commented Jun 17, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

codecov bot commented Jun 17, 2025 •

edited

Loading

Uh oh!

PPsyrius left a comment

Uh oh!

arkid15r left a comment

Uh oh!

Uh oh!

sonarqubecloud bot commented Jun 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Update pytest configuration #2640

Update pytest configuration #2640

Uh oh!

Conversation

KJhellico commented Jun 17, 2025

Proposed change

Type of change

Checklist

Uh oh!

coderabbitai bot commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Summary by CodeRabbit

Walkthrough

Changes

Suggested labels

Suggested reviewers

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

codecov bot commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

PPsyrius left a comment

Choose a reason for hiding this comment

Uh oh!

arkid15r left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonarqubecloud bot commented Jun 17, 2025

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai bot commented Jun 17, 2025 •

edited

Loading

codecov bot commented Jun 17, 2025 •

edited

Loading