Bump numpy to 2.3.0 #2633

KJhellico · 2025-06-15T08:59:37Z

Proposed change

Bump numpy to 2.3.0 (for Python 3.11+).

Type of change

New country/market holidays support (thank you!)
Supported country/market holidays update (calendar discrepancy fix, localization)
Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
Dependency update (version deprecation/pin/upgrade)
Bugfix (non-breaking change which fixes an issue)
Breaking change (a code change causing existing functionality to break)
New feature (new holidays functionality in general)

Checklist

I've followed the contributing guidelines
I've successfully run make check, all checks and tests are green

coderabbitai · 2025-06-15T08:59:42Z

Summary by CodeRabbit

Chores
- Updated test dependencies to use specific numpy versions for different Python versions.
Refactor
- Moved the numpy import to the top of the test module for improved clarity and consistency.

Walkthrough

The changes update the numpy version requirements in the test dependencies to be specific to the Python version in use. Additionally, the numpy import in a test file is moved from within a function to the top of the file, making it available throughout the module.

Changes

File(s)	Change Summary
requirements/tests.txt	Refined numpy version constraints: now uses 2.2.6 for Python 3.10 and 2.3.0 for Python 3.11+.
tests/third_party/test_numpy.py	Moved `import numpy as np` from inside a test method to the module-level import section.

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate Unit Tests

Create PR with Unit Tests
Commit Unit Tests in branch upd-numpy
Post Copyable Unit Tests in Comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai auto-generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

sonarqubecloud · 2025-06-15T09:00:27Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

codecov · 2025-06-15T09:01:27Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3d11b59) to head (03ef8b0).
Report is 1 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff            @@
##               dev     #2633   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          232       232           
  Lines        14739     14739           
  Branches      2057      2057           
=========================================
  Hits         14739     14739

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

PPsyrius

LGTM 🛠️

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3d11b59 and 03ef8b0.

📒 Files selected for processing (2)

requirements/tests.txt (1 hunks)
tests/third_party/test_numpy.py (1 hunks)

🧰 Additional context used

🪛 Pylint (3.3.7)

tests/third_party/test_numpy.py

[error] 15-15: Unable to import 'numpy'

(E0401)

⏰ Context from checks skipped due to timeout of 300000ms (1)

GitHub Check: Test Python 3.13 on windows-latest

🔇 Additional comments (1)

requirements/tests.txt (1)

6-7: Specify numpy versions per Python version.
Splitting into numpy==2.2.6 for Python 3.10 and numpy==2.3.0 for Python 3.11+ ensures compatibility with the respective interpreters and replaces the previous blanket version.

tests/third_party/test_numpy.py

Bump numpy to 2.3.0

03ef8b0

KJhellico requested review from PPsyrius and arkid15r as code owners June 15, 2025 08:59

github-actions bot added the test label Jun 15, 2025

PPsyrius approved these changes Jun 15, 2025

View reviewed changes

coderabbitai bot reviewed Jun 15, 2025

View reviewed changes

tests/third_party/test_numpy.py Show resolved Hide resolved

arkid15r added this pull request to the merge queue Jun 15, 2025

Merged via the queue into vacanza:dev with commit 8fa07c4 Jun 15, 2025
33 checks passed

KJhellico deleted the upd-numpy branch June 15, 2025 19:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Bump numpy to 2.3.0 #2633

Bump numpy to 2.3.0 #2633

Uh oh!

KJhellico commented Jun 15, 2025

Uh oh!

coderabbitai bot commented Jun 15, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

sonarqubecloud bot commented Jun 15, 2025

Uh oh!

codecov bot commented Jun 15, 2025 •

edited

Loading

Uh oh!

PPsyrius left a comment

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Bump numpy to 2.3.0 #2633

Bump numpy to 2.3.0 #2633

Uh oh!

Conversation

KJhellico commented Jun 15, 2025

Proposed change

Type of change

Checklist

Uh oh!

coderabbitai bot commented Jun 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Walkthrough

Changes

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

sonarqubecloud bot commented Jun 15, 2025

Quality Gate passed

Uh oh!

codecov bot commented Jun 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

PPsyrius left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai bot commented Jun 15, 2025 •

edited

Loading

codecov bot commented Jun 15, 2025 •

edited

Loading