Update countries/financial with absolute imports #2599

laurentco · 2025-06-05T09:18:20Z

Proposed change

Some of the modules in this library are imported with relative imports, whilst others are imported with absolute imports.
The relative imports fail in some cases, the case I am facing right now is when trying to import the holidays library into a Cloud Composer (Airflow on GCP) plugin.

Whilst this may seem like a very specific case to address here, I see no reason for having a mix of relative and absolute imports in the codebase, especially if this is the source of potential errors: If it works in all cases with absolute imports (as far as I'm aware it should) then let's make it consistent and have all absolute imports across the code base.

Type of change

New country/market holidays support (thank you!)
Supported country/market holidays update (calendar discrepancy fix, localization)
Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
Dependency update (version deprecation/pin/upgrade)
Bugfix (non-breaking change which fixes an issue)
Breaking change (a code change causing existing functionality to break)
New feature (new holidays functionality in general)

Checklist

I've followed the contributing guidelines
I've successfully run make check, all checks and tests are green

coderabbitai · 2025-06-05T09:18:27Z

Summary by CodeRabbit

Chores
- Updated the CONTRIBUTORS list to include Laurent Comparet.
- Changed import statements to use absolute imports for improved clarity.
- Updated linter directive comments for consistency.

Summary by CodeRabbit

Chores
- Updated the CONTRIBUTORS list to include Laurent Comparet.
- Changed import statements in select modules to use absolute import paths for improved consistency. No functional changes for end-users.

Walkthrough

The update switches relative import statements to absolute imports in two __init__.py files and adds a new name, "Laurent Comparet," to the CONTRIBUTORS list. No changes were made to logic, error handling, or exported entities.

Changes

File(s)	Change Summary
holidays/countries/init.py	Changed all relative imports to absolute imports using the full package path.
holidays/financial/init.py	Updated import statements from relative to absolute imports with the full package path.
CONTRIBUTORS	Added "Laurent Comparet" as a new contributor in the appropriate alphabetical position.

Possibly related PRs

Add French Southern Territories holidays #2442: Adds a new country holiday class and imports it into holidays/countries/__init__.py, related to import statement changes in the same module.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9bcaa7d and 5fb2f41.

📒 Files selected for processing (2)

holidays/countries/__init__.py (1 hunks)
holidays/financial/__init__.py (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

holidays/countries/__init__.py (1)

Learnt from: PPsyrius
PR: vacanza/holidays#2599
File: holidays/countries/__init__.py:193-193
Timestamp: 2025-06-05T09:31:22.724Z
Learning: For the holidays Python library, when encountering line length or formatting issues, suggest contributors run `make pre-commit` to auto-format their files instead of providing specific manual formatting fixes like line splitting or noqa comments.

🔇 Additional comments (3)

holidays/financial/__init__.py (2)

13-13: Linter directive updated from Flake8 to Ruff.
Switching the noqa directive to Ruff aligns with our linting migration. Confirm CI and contributor tooling now use Ruff exclusively.

15-18: Absolute imports in financial subpackage.
Replacing relative imports with absolute holidays.financial.* paths improves reliability in environments like Cloud Composer. Module names and aliases appear correct.

holidays/countries/__init__.py (1)

13-13: Linter directive updated to Ruff.
Good catch updating the file-level noqa to Ruff. Ensure all pre-commit hooks and CI enforce Ruff rules.

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 2

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 32a0f7c and a4f936c.

📒 Files selected for processing (3)

CONTRIBUTORS (1 hunks)
holidays/countries/__init__.py (1 hunks)
holidays/financial/__init__.py (1 hunks)

🧰 Additional context used

🪛 Ruff (0.11.9)

holidays/countries/__init__.py

77-77: Line too long (105 > 99)

(E501)

193-193: Line too long (106 > 99)

(E501)

🪛 Pylint (3.3.7)

holidays/countries/__init__.py

[convention] 77-77: Line too long (105/100)

(C0301)

[convention] 193-193: Line too long (106/100)

(C0301)

🔇 Additional comments (3)

CONTRIBUTORS (1)

87-87: New contributor added
The entry “Laurent Comparet” is inserted in the correct alphabetical position.

holidays/financial/__init__.py (1)

15-18: Converted to absolute imports
The switch from relative (from .module) to absolute (from holidays.financial.module) imports is consistent and preserves the public API.

holidays/countries/__init__.py (1)

15-203: Converted to absolute imports
All country modules now use absolute paths (holidays.countries.*) instead of relative imports. This standardizes import style without altering functionality.

🧰 Tools

🪛 Ruff (0.11.9)

77-77: Line too long (105 > 99)

(E501)

193-193: Line too long (106 > 99)

(E501)

🪛 Pylint (3.3.7)

[convention] 77-77: Line too long (105/100)

(C0301)

[convention] 193-193: Line too long (106/100)

(C0301)

holidays/countries/__init__.py

codecov · 2025-06-06T02:41:57Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7618b69) to head (5fb2f41).
Report is 2 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff            @@
##               dev     #2599   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          227       227           
  Lines        14470     14470           
  Branches      2027      2027           
=========================================
  Hits         14470     14470

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

PPsyrius

LGTM

KJhellico

LGTM.

sonarqubecloud · 2025-06-07T00:20:15Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

arkid15r

@laurentco thanks for the contribution 👍

removing relative imports

a4f936c

coderabbitai bot reviewed Jun 5, 2025

View reviewed changes

holidays/countries/__init__.py Outdated Show resolved Hide resolved

holidays/countries/__init__.py Outdated Show resolved Hide resolved

ran pre-commit

9e477e7

laurentco marked this pull request as ready for review June 6, 2025 02:36

laurentco requested review from arkid15r and KJhellico as code owners June 6, 2025 02:36

Merge branch 'dev' into remove-relative-imports

9bcaa7d

laurentco requested a review from PPsyrius June 6, 2025 02:38

PPsyrius previously approved these changes Jun 6, 2025

View reviewed changes

KJhellico previously approved these changes Jun 6, 2025

View reviewed changes

flake8 -> ruff

5fb2f41

arkid15r dismissed stale reviews from KJhellico and PPsyrius via 5fb2f41 June 7, 2025 00:19

arkid15r changed the title ~~Removing relative imports~~ Update countries/financial with absolute imports Jun 7, 2025

PPsyrius approved these changes Jun 7, 2025

View reviewed changes

arkid15r added this pull request to the merge queue Jun 7, 2025

arkid15r reviewed Jun 7, 2025

View reviewed changes

Merged via the queue into vacanza:dev with commit e6035f1 Jun 7, 2025
33 checks passed

arkid15r mentioned this pull request Jun 16, 2025

v0.75 #2639

Merged

coderabbitai bot mentioned this pull request Jun 30, 2025

Add Saint Vincent and the Grenadines holidays #2608

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Update countries/financial with absolute imports #2599

Update countries/financial with absolute imports #2599

Uh oh!

laurentco commented Jun 5, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jun 5, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jun 6, 2025 •

edited

Loading

Uh oh!

PPsyrius left a comment

Uh oh!

KJhellico left a comment

Uh oh!

sonarqubecloud bot commented Jun 7, 2025

Uh oh!

arkid15r left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Update countries/financial with absolute imports #2599

Update countries/financial with absolute imports #2599

Uh oh!

Conversation

laurentco commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed change

Type of change

Checklist

Uh oh!

coderabbitai bot commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Summary by CodeRabbit

Walkthrough

Changes

Possibly related PRs

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

PPsyrius left a comment

Choose a reason for hiding this comment

Uh oh!

KJhellico left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Jun 7, 2025

Quality Gate passed

Uh oh!

arkid15r left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

laurentco commented Jun 5, 2025 •

edited

Loading

coderabbitai bot commented Jun 5, 2025 •

edited

Loading

codecov bot commented Jun 6, 2025 •

edited

Loading