Update Hungary holidays: update 1991-2026 special holidays #2568
Conversation
adding special holidays for 2007, 2008, 2009 Signed-off-by: prokaj <79016705+prokaj@users.noreply.github.com>
comma was missing Signed-off-by: prokaj <79016705+prokaj@users.noreply.github.com>
format update Signed-off-by: prokaj <79016705+prokaj@users.noreply.github.com>
adding 2002, 2003, 2004, 2005 and 2026 Signed-off-by: prokaj <79016705+prokaj@users.noreply.github.com>
Summary by CodeRabbit
Summary by CodeRabbit
WalkthroughThe Hungary holiday data was updated to add substituted holiday dates and reference links for the years 1991, 1992, 1993, 1994, 1997, 1998, 1999, 2001, 2002, 2003, 2004, 2005, 2007, 2008, 2009, and 2026. These updates expand the Changes
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Pull Request Overview
Adds missing special public holiday entries for Hungary in years 2002–2009 (excluding 2006) and 2026, along with corresponding legal references in the docstring.
- Updated the docstring to include government decree links for 2002–2005, 2007–2009, and 2026
- Populated
special_public_holidaysmapping with date tuples for those years - Left 2006 out as there were no special holidays
Comments suppressed due to low confidence (1)
holidays/countries/hungary.py:149
- No tests were added for the new
special_public_holidaysentries (2002–2005, 2007–2009, 2026). Adding unit tests for these years will help validate the mapping values.
2002: (
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2568 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 229 229
Lines 14571 14571
Branches 2039 2039
=========================================
Hits 14571 14571 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Feel free to add your name to the CONTRIBUTORS file as well 👍
Signed-off-by: prokaj <79016705+prokaj@users.noreply.github.com>
There was a problem hiding this comment.
I found some additional references for 1992-2001 here based from your sources (pre-archived for you here) 👀
For 2001 which only got extra rest day instead of the usual holiday swap, maybe something like this:
# Day off.
2001: (DEC, 31, tr("Pihenőnap")),Keep in mind that you may need to add this extra entry to all Hungary's .po translation files as well [1] [2] [3]
|
This is a busy week. I will do it during the weekend.
…________________________________________
Feladó: Arkadii Yakovets ***@***.***>
Elküldve: 2025. június 3., kedd 21:21
Címzett: vacanza/holidays
Másolatot kap: Dr. Prokaj Vilmos; Mention
Tárgy: Re: [vacanza/holidays] Update Hungary holidays: update 2002-2026 special holidays (PR #2568)
@arkid15r commented on this pull request.
@prokaj<https://github.com/prokaj> could you take a look at the code review suggestions?
Thank you!
—
Reply to this email directly, view it on GitHub<#2568 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AS23GAMMAUGRCHVW3VMAJRL3BXYS7AVCNFSM6AAAAAB54WRN4KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQOJTHAYDCNJWGE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Thank you @prokaj |
Co-authored-by: Panpakorn Siripanich <19505219+PPsyrius@users.noreply.github.com> Signed-off-by: prokaj <79016705+prokaj@users.noreply.github.com>
Co-authored-by: Panpakorn Siripanich <19505219+PPsyrius@users.noreply.github.com> Signed-off-by: prokaj <79016705+prokaj@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
holidays/countries/hungary.py(3 hunks)
🧰 Additional context used
🧠 Learnings (1)
holidays/countries/hungary.py (1)
Learnt from: KJhellico
PR: vacanza/holidays#2398
File: tests/countries/test_guinea.py:237-239
Timestamp: 2025-04-02T18:38:35.164Z
Learning: In the vacanza/holidays project, the method assertLocalizedHolidays in country test files should be called with positional parameters rather than named parameters to maintain consistency with the rest of the codebase.
🪛 Pylint (3.3.7)
holidays/countries/hungary.py
[convention] 120-120: Line too long (112/100)
(C0301)
[convention] 121-121: Line too long (112/100)
(C0301)
[convention] 122-122: Line too long (112/100)
(C0301)
[convention] 123-123: Line too long (113/100)
(C0301)
[convention] 124-124: Line too long (113/100)
(C0301)
[convention] 125-125: Line too long (114/100)
(C0301)
[convention] 126-126: Line too long (114/100)
(C0301)
[convention] 141-141: Line too long (113/100)
(C0301)
🔇 Additional comments (9)
holidays/countries/hungary.py (9)
120-126: Archived references added for early special holidays.
The web.archive.org links for 2002–2009 and 2026 align with existing docstring style and provide durable references.Also applies to: 141-141
🧰 Tools
🪛 Pylint (3.3.7)
[convention] 120-120: Line too long (112/100)
(C0301)
[convention] 121-121: Line too long (112/100)
(C0301)
[convention] 122-122: Line too long (112/100)
(C0301)
[convention] 123-123: Line too long (113/100)
(C0301)
[convention] 124-124: Line too long (113/100)
(C0301)
[convention] 125-125: Line too long (114/100)
(C0301)
[convention] 126-126: Line too long (114/100)
(C0301)
149-152: Add special holidays for 2002.
The nested tuples for Aug 19→Aug 10 and Dec 24→Dec 28 are correctly formatted and positioned.
153-157: Add special holidays for 2003.
Entries for May 2→Apr 26, Oct 24→Oct 18, and Dec 24→Dec 13 follow the established pattern.
158-161: Add special holidays for 2004.
The Jan 2→Jan 10 and Dec 24→Dec 18 tuples match the nested tuple convention.
162-165: Add special holidays for 2005.
Mar 14→Mar 19 and Oct 31→Nov 5 are properly declared within the tuple.
166-172: Add special holidays for 2007.
All six substituted dates (Mar 16, Apr 30, Oct 22, Nov 2, Dec 24, Dec 31) are present and correctly formatted.
174-178: Add special holidays for 2008.
May 2→Apr 26, Oct 24→Oct 18, and Dec 24→Dec 20 are consistent with the existing data structure.
179-183: Add special holidays for 2009.
The entries for Jan 2→Mar 28, Aug 21→Aug 29, and Dec 24→Dec 19 are correctly inserted.
248-252: Add special holidays for 2026.
The Jan 2→Jan 10, Aug 21→Aug 8, and Dec 24→Dec 12 tuples align perfectly with the pattern of previous years.
Signed-off-by: prokaj <79016705+prokaj@users.noreply.github.com>
fix typos, missing commas Signed-off-by: prokaj <79016705+prokaj@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 4
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
holidays/countries/hungary.py(3 hunks)
🧰 Additional context used
🧠 Learnings (1)
holidays/countries/hungary.py (1)
Learnt from: KJhellico
PR: vacanza/holidays#2398
File: tests/countries/test_guinea.py:237-239
Timestamp: 2025-04-02T18:38:35.164Z
Learning: In the vacanza/holidays project, the method assertLocalizedHolidays in country test files should be called with positional parameters rather than named parameters to maintain consistency with the rest of the codebase.
🪛 Ruff (0.11.9)
holidays/countries/hungary.py
120-120: Line too long (104 > 99)
(E501)
129-129: Trailing whitespace
(W291)
176-176: SyntaxError: Expected ',', found int
181-181: SyntaxError: Expected ',', found int
185-185: Trailing whitespace
(W291)
🪛 Pylint (3.3.7)
holidays/countries/hungary.py
[error] 176-176: Parsing failed: 'invalid syntax. Perhaps you forgot a comma? (holidays.countries.hungary, line 176)'
(E0001)
🔇 Additional comments (1)
holidays/countries/hungary.py (1)
120-153: Good work on the comprehensive documentation updates.The archived reference links follow the established pattern and ensure future availability of the legal sources.
🧰 Tools
🪛 Ruff (0.11.9)
120-120: Line too long (104 > 99)
(E501)
129-129: Trailing whitespace
(W291)
some lines were too long Signed-off-by: prokaj <79016705+prokaj@users.noreply.github.com>
|
To complete and check the data I used a subscription based database. It is indicated in the doc string. |
Signed-off-by: prokaj <79016705+prokaj@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> Signed-off-by: prokaj <79016705+prokaj@users.noreply.github.com>
Signed-off-by: prokaj <79016705+prokaj@users.noreply.github.com>
|
|
In the latest version of hu2002-2009
I hope it can be merged now into the dev branch |
Proposed change
Years before 2010 and after 2025 were missing from the list of special public holidays for Hungary.
I added these to the file countries/hungary.py using another legal source (links included in the doc string)
There were no such item in 2006 so this year is empty.
Type of change
holidaysfunctionality in general)Checklist
make check, all checks and tests are green