Add Guinea holidays #2398
Add Guinea holidays #2398
Conversation
Summary by CodeRabbit
WalkthroughThis pull request adds support for Guinea within the holiday framework, updating the Changes
Assessment against linked issues
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 300000ms (1)
🔇 Additional comments (1)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Actionable comments posted: 5
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (11)
AUTHORS.md(1 hunks)README.md(2 hunks)holidays/calendars/islamic.py(3 hunks)holidays/countries/__init__.py(1 hunks)holidays/countries/guinea.py(1 hunks)holidays/groups/islamic.py(1 hunks)holidays/locale/en_US/LC_MESSAGES/GN.po(1 hunks)holidays/locale/fr/LC_MESSAGES/GN.po(1 hunks)holidays/registry.py(1 hunks)scripts/calendar/islamic_generator.py(1 hunks)tests/countries/test_guinea.py(1 hunks)
🧰 Additional context used
🧬 Code Definitions (2)
holidays/countries/__init__.py (1)
holidays/countries/guinea.py (3)
Guinea(21-97)GN(100-101)GIN(104-105)
tests/countries/test_guinea.py (1)
holidays/countries/guinea.py (3)
Guinea(21-97)GN(100-101)GIN(104-105)
🔇 Additional comments (24)
AUTHORS.md (1)
97-97: New contributor added correctly.The name "Nalin Gupta" has been added to the AUTHORS.md file, maintaining proper alphabetical order. This correctly attributes the contributor who implemented the Guinea holidays support.
holidays/countries/__init__.py (1)
78-78: Guinea import added correctly.The import statement
from .guinea import Guinea, GN, GINhas been properly added, placing it alphabetically between Guernsey and Haiti. This allows the Guinea holiday class and its country code aliases to be accessible through the countries package.scripts/calendar/islamic_generator.py (1)
71-71: Islamic holiday added appropriately.The Laylat Al-Qadr (The Night of Power) holiday has been added to the ISLAMIC_HOLIDAYS tuple with the correct format (9, 27, "LAYLAT_AL_QADR"). This is an important Islamic observance that occurs on the 27th day of the 9th month in the Islamic calendar, which would be relevant for Guinea's holiday calendar.
README.md (2)
102-102: Country count updated correctly.The number of supported country codes has been updated from 161 to 162, reflecting the addition of Guinea to the supported countries.
586-591: Guinea entry added properly to the country table.The Guinea entry has been added to the table with the following details:
- Country name: Guinea
- Country code: GN
- No subdivisions specified
- Supported languages: en_US, fr (with fr as the default, indicated by the bold formatting)
- No additional holiday categories
This properly documents Guinea's integration into the holidays library and matches the implementation details from the Guinea class.
holidays/registry.py (1)
87-87: Correctly added Guinea to the country registry.The entry follows the proper pattern with country name, ISO 3166-1 alpha-2 code (GN), and alpha-3 code (GIN). The alphabetical placement between Guernsey and Haiti is correct.
holidays/groups/islamic.py (1)
298-306: Well-implemented Laylat al-Qadr holiday support.The method follows the established pattern in the codebase with proper documentation, including the holiday description and Wikipedia reference. Implementation correctly calls the appropriate calendar date retrieval method.
holidays/locale/en_US/LC_MESSAGES/GN.po (1)
1-84: Good addition of English translations for Guinea holidays.The localization file includes all necessary metadata and properly translates holiday names from French to English. The translations are accurate and follow the established pattern for holiday names.
tests/countries/test_guinea.py (9)
19-23: Good test class setupThe class properly inherits from CommonCountryTests and TestCase, with correct initialization of the Guinea class in setUpClass.
24-26: Effective alias testingCorrectly verifies that GN and GIN are valid aliases for Guinea.
27-29: Good boundary condition checkAppropriate test to ensure no holidays are returned for years before Guinea's independence (1958).
30-34: Well-implemented date range testingTest correctly verifies Second Republic Day is only observed from 1958 to 2021 and not afterward.
35-39: Proper holiday range verificationTest properly checks that All Saints' Day is only observed between 1958 and 2021.
48-64: Comprehensive Islamic holiday testGood test coverage for Eid al-Fitr dates across multiple years, accounting for the lunar calendar shift.
65-80: Thorough Christian holiday testingAppropriate verification of Easter Monday dates which follow the Christian calendar's movable feast calculation.
130-146: Good testing of Laylat al-Qadr datesComprehensive test coverage for the Night of Power holiday across multiple years with correct Islamic calendar dates.
147-162: Complete year testExcellent comprehensive test that verifies all holidays for 2021, ensuring the holiday set is complete and accurate.
holidays/calendars/islamic.py (3)
34-34: New holiday constant added correctly.The constant
LAYLAT_AL_QADRfollows the same naming pattern as existing holiday constants, maintaining consistency in the codebase.
2236-2390: Comprehensive date mapping for Laylat al-Qadr holiday.The
LAYLAT_AL_QADR_DATESdictionary provides date mappings spanning from 1925 to 2077, consistent with other holiday date dictionaries in this file. The format adheres to the established pattern using month constants and day numbers.
3850-3851: Method implementation follows established pattern.The
laylat_al_qadr_datesmethod correctly implements the holiday date retrieval using the same pattern as other holiday methods, leveraging the_get_holidayhelper. This maintains consistency and reduces code duplication.holidays/countries/guinea.py (4)
21-37: Class definition looks good with comprehensive documentation.The class is correctly set up with proper inheritance structure and includes useful reference links in the documentation. The country code, language settings, and start year are all properly defined.
41-54: Constructor implementation is solid.The constructor properly initializes all parent classes and handles the optional parameter for Islamic holiday estimation. The code follows the project patterns well.
100-106: Alias classes look good.The GN and GIN classes provide useful country code aliases for the Guinea class.
108-163: Islamic holidays dates implementation looks correct.The implementation provides specific dates for Islamic holidays from 2015 to 2025, which is particularly useful for these lunar calendar-based holidays. The use of tuples for years with multiple dates is handled properly.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2398 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 208 209 +1
Lines 13244 13301 +57
Branches 1899 1906 +7
=========================================
+ Hits 13244 13301 +57 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: nalin-28 <nalinguptaofficial@gmail.com>
Make changes to Assumption day and Tabaski Signed-off-by: nalin-28 <nalinguptaofficial@gmail.com>
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (5)
AUTHORS.md(1 hunks)README.md(1 hunks)holidays/countries/__init__.py(1 hunks)holidays/groups/islamic.py(1 hunks)holidays/registry.py(1 hunks)
🧰 Additional context used
🧬 Code Definitions (2)
holidays/countries/__init__.py (1)
holidays/countries/guinea.py (3)
Guinea(21-97)GN(100-101)GIN(104-105)
holidays/groups/islamic.py (1)
holidays/calendars/islamic.py (1)
laylat_al_qadr_dates(3850-3851)
🪛 Ruff (0.8.2)
holidays/groups/islamic.py
301-301: Blank line contains whitespace
Remove whitespace from blank line
(W293)
🔇 Additional comments (5)
AUTHORS.md (1)
99-99: Author addition looks good!Welcome to the project, Nalin Gupta. The addition maintains proper alphabetical ordering in the authors list.
holidays/countries/__init__.py (1)
78-78: Import statement correctly follows project conventionsThe import for Guinea maintains proper alphabetical ordering between Ghana and Haiti, and follows the standard pattern of importing the country class along with its ISO code aliases.
README.md (1)
585-591: Guinea entry correctly added to READMEThe Guinea entry follows the established format and includes proper language support information. The table formatting is maintained consistently with English (en_US) and French (fr) as supported languages, with French marked as the default.
holidays/registry.py (1)
87-87: Registry entry properly formattedThe Guinea entry in the COUNTRIES dictionary follows the project's conventions with proper ISO codes (GN and GIN) and maintains alphabetical ordering between Guernsey and Haiti.
holidays/groups/islamic.py (1)
305-307: Implementation improved for Laylat al-Qadr calculation.The code now uses a dedicated method
laylat_al_qadr_dates()instead of deriving the date from Ramadan's start date. This is a better approach as it encapsulates the specific calculation logic for this holiday.
Fix Independence spelling Signed-off-by: nalin-28 <nalinguptaofficial@gmail.com>
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (1)
holidays/countries/guinea.py (1)
65-72: 🧹 Nitpick (assertive)Add an explanatory comment for the date range condition
The implementation correctly restricts these holidays to years 1958-2021, but add a comment explaining why they stopped being recognized after 2021.
if self._year <= 2021 and self._year >= 1958: + # Guinea stopped recognizing Second Republic Day as a public holiday from 2021 onwards # Second Republic Day. self._add_holiday_apr_3(tr("Jour de la Deuxième République")) if self._year <= 2021 and self._year >= 1958: + # Guinea stopped recognizing All Saint's Day as a public holiday from 2021 onwards # All Saint's Day. self._add_all_saints_day(tr("La Toussaint"))
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
holidays/countries/guinea.py(1 hunks)tests/countries/test_guinea.py(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
holidays/countries/guinea.py (1)
Learnt from: nalin-28
PR: vacanza/holidays#2398
File: holidays/countries/guinea.py:65-72
Timestamp: 2025-04-01T06:13:19.221Z
Learning: Guinea stopped recognizing "Second Republic Day" and "All Saint's Day" as public holidays from 2021 onwards.
🧬 Code Definitions (2)
tests/countries/test_guinea.py (1)
holidays/countries/guinea.py (3)
Guinea(21-95)GN(98-99)GIN(102-103)
holidays/countries/guinea.py (2)
holidays/calendars/islamic.py (1)
_CustomIslamicHolidays(3881-3882)holidays/groups/islamic.py (5)
IslamicHolidays(20-416)_add_eid_al_fitr_day(152-163)_add_eid_al_adha_day(109-120)_add_mawlid_day(319-329)_add_laylat_al_qadr_day(298-307)
🔇 Additional comments (24)
tests/countries/test_guinea.py (18)
1-17: LGTM! Well-structured imports and setup.The imports are appropriate and follow the project's conventions.
19-23: Test class correctly inherits from CommonCountryTestsThe test class follows the project's standard pattern by inheriting from the CommonCountryTests class and setting up the Guinea class.
24-26: Proper validation of country aliasesGood practice to verify that all aliases (GN, GIN) correctly map to the main Guinea class.
27-29: Correct check for no holidays before independenceGood test to verify that no holidays exist before Guinea's independence in 1958.
30-34: Good test for Second Republic Day with appropriate date rangeThe test correctly verifies this holiday exists from 1958 to 2021 and is absent from 2022 onwards, matching the implementation.
35-39: Good test for All Saints' Day with appropriate date rangeThe test correctly verifies this holiday exists from 1958 to 2021 and is absent from 2022 onwards, matching the implementation.
40-42: New Year's Day test is properly implementedThe test correctly verifies this holiday for the appropriate years.
43-47: Africa Day test is properly implementedThe test correctly verifies this holiday for the appropriate years.
48-64: Comprehensive test for Eid al-Fitr with specific datesGood test that verifies this Islamic holiday's specific dates for each year.
65-80: Comprehensive test for Easter Monday with specific datesGood test that verifies this Christian holiday's specific dates for each year.
81-83: Labor Day test is properly implementedThe test correctly verifies this holiday for the appropriate years.
84-87: Assumption of Mary test is properly implementedThe test correctly verifies this holiday for the appropriate years.
88-92: Independence Day test is properly implementedThe test correctly verifies this holiday for the appropriate years.
93-95: Christmas Day test is properly implementedThe test correctly verifies this holiday for the appropriate years.
96-112: Comprehensive test for Mawlid Day with specific datesGood test that verifies this Islamic holiday's specific dates for each year.
113-129: Comprehensive test for Eid al-Adha Day with specific datesGood test that verifies this Islamic holiday's specific dates for each year.
130-146: Comprehensive test for Laylat al-Qadr Day with specific datesGood test that verifies this Islamic holiday's specific dates for each year.
147-163: Good comprehensive test for 2021 holidaysThis test verifies all holidays for 2021, which is a good integration test to ensure everything works together properly.
holidays/countries/guinea.py (6)
13-19: LGTM! Appropriate imports for holidays implementation.The imports cover all necessary components for defining Guinea holidays.
21-37: Well-structured Guinea class with proper documentationGood job defining the country code, supported languages, and providing reference documentation.
41-54: LGTM! Constructor correctly initializes parent classesThe constructor properly initializes all parent classes and passes the custom Islamic holidays implementation.
94-96: LGTM! Good implementation of Laylat al-Qadr holidayThis Islamic holiday is properly implemented using the custom Islamic calendar dates.
98-103: LGTM! Country code aliases correctly definedThe GN and GIN aliases are properly implemented as subclasses of Guinea.
106-161: LGTM! Comprehensive Islamic holiday dates implementationThe custom Islamic holiday dates are well-defined for years 2015-2025, providing accurate holiday dates for Guinea.
Fix Spelling Signed-off-by: nalin-28 <nalinguptaofficial@gmail.com>
Fix Spelling Errors Signed-off-by: nalin-28 <nalinguptaofficial@gmail.com>
Fix Spelling Mistake Signed-off-by: nalin-28 <nalinguptaofficial@gmail.com>
Fix Trailing Whitespace Signed-off-by: nalin-28 <nalinguptaofficial@gmail.com>
Co-authored-by: Panpakorn Siripanich <19505219+PPsyrius@users.noreply.github.com> Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> Signed-off-by: nalin-28 <nalinguptaofficial@gmail.com>
There was a problem hiding this comment.
Actionable comments posted: 7
♻️ Duplicate comments (2)
tests/countries/test_guinea.py (1)
148-149: 🧹 Nitpick (assertive)Add source reference for test data.
As suggested in a past review comment, consider adding a link to the source you used for the 2021 test case.
- def test_2021(self): + def test_2021(self): + # Source: https://www.timeanddate.com/holidays/guinea/2021holidays/countries/guinea.py (1)
56-94: 🧹 Nitpick (assertive)Consider ordering holidays chronologically.
As suggested in a past review comment, consider ordering the holidays chronologically, with Gregorian calendar holidays first and Islamic holidays afterward. This would improve readability and maintenance.
def _populate_public_holidays(self): # New Year's Day. self._add_new_years_day(tr("Nouvel an")) - # Eid al-Fitr. - self._add_eid_al_fitr_day(tr("Korité")) - # Easter Monday. self._add_easter_monday(tr("Le lundi de Pâques")) if self._year <= 2021: # Second Republic Day. self._add_holiday_apr_3(tr("Jour de la Deuxième République")) - # All Saint's Day. - self._add_all_saints_day(tr("La Toussaint")) - # Labor Day. self._add_labor_day(tr("Fête du Travail")) # Africa Day. self._add_africa_day(tr("Anniversaire de l'OUA")) - # Eid al-Adha. - self._add_eid_al_adha_day(tr("Tabaski")) - # Assumption Day. self._add_assumption_of_mary_day(tr("Assomption de Marie")) # Independence Day. self._add_holiday_oct_2(tr("Fête de l'indépendance de la Guinée")) + if self._year <= 2021: + # All Saint's Day. + self._add_all_saints_day(tr("La Toussaint")) + # Christmas Day. self._add_christmas_day(tr("Noël")) + # Eid al-Fitr. + self._add_eid_al_fitr_day(tr("Korité")) + + # Eid al-Adha. + self._add_eid_al_adha_day(tr("Tabaski")) + # Prophet's Birthday. self._add_mawlid_day(tr("Maouloud")) # Night of Power. self._add_laylat_al_qadr_day(tr("Lailatoul Qadr"))
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (5)
holidays/countries/guinea.py(1 hunks)holidays/locale/en_US/LC_MESSAGES/GN.po(1 hunks)holidays/locale/fr/LC_MESSAGES/GN.po(1 hunks)scripts/calendar/islamic_generator.py(1 hunks)tests/countries/test_guinea.py(1 hunks)
🧰 Additional context used
🧠 Learnings (3)
holidays/locale/en_US/LC_MESSAGES/GN.po (1)
Learnt from: KJhellico
PR: vacanza/holidays#2398
File: holidays/locale/fr/LC_MESSAGES/GN.po:31-83
Timestamp: 2025-03-31T20:25:12.808Z
Learning: In the holidays library, French (fr) is the default language for Guinea. This means that message IDs (msgid) in the PO files are already in French, and message strings (msgstr) in the French locale files can remain empty, as no translation is needed.
holidays/locale/fr/LC_MESSAGES/GN.po (1)
Learnt from: KJhellico
PR: vacanza/holidays#2398
File: holidays/locale/fr/LC_MESSAGES/GN.po:31-83
Timestamp: 2025-03-31T20:25:12.808Z
Learning: In the holidays library, French (fr) is the default language for Guinea. This means that message IDs (msgid) in the PO files are already in French, and message strings (msgstr) in the French locale files can remain empty, as no translation is needed.
holidays/countries/guinea.py (1)
Learnt from: nalin-28
PR: vacanza/holidays#2398
File: holidays/countries/guinea.py:65-72
Timestamp: 2025-04-01T06:13:19.221Z
Learning: Guinea stopped recognizing "Second Republic Day" and "All Saint's Day" as public holidays from 2021 onwards.
🧬 Code Definitions (1)
tests/countries/test_guinea.py (1)
holidays/countries/guinea.py (3)
Guinea(21-94)GN(97-98)GIN(101-102)
🔇 Additional comments (7)
scripts/calendar/islamic_generator.py (1)
71-72: Good addition of LAYLAT_AL_QADR holiday for Guinea (GN) and Côte d'Ivoire (CI).The addition of this Islamic holiday follows the established pattern and is properly positioned chronologically - it appears after other 9th month entries and before the 10th month entries. The formatting and comment style match the existing conventions.
holidays/locale/en_US/LC_MESSAGES/GN.po (2)
33-35: Translations look good and follow proper structure.The translation for "Nouvel an" to "New Year's Day" is correct and follows the standard format.
81-83: Good translation of Islamic holiday.The translation of "Lailatoul Qadr" to "The Night of Power" correctly captures the meaning of this important Islamic observance.
holidays/locale/fr/LC_MESSAGES/GN.po (1)
31-83: Empty message strings are correct for default language.Based on the retrieved learning, French is the default language for Guinea in this library, so the empty message strings are intentional and correct. The msgid values are already in French, making translation unnecessary.
holidays/countries/guinea.py (3)
21-40: Class definition looks good with proper documentation.The Guinea class is well defined with appropriate documentation, references, and metadata settings. The start year of 1959 correctly represents the year after Guinea gained independence from France.
97-102: Country code aliases properly defined.The aliases GN and GIN are correctly implemented as subclasses of Guinea.
105-160: Islamic holiday definitions look good.The GuineaIslamicHolidays class correctly defines specific dates for Islamic holidays from 2015 to 2025, which is important for accurate holiday calculations due to the lunar Islamic calendar.
Signed-off-by: nalin-28 <nalinguptaofficial@gmail.com>
Fix WhiteSpace Signed-off-by: nalin-28 <nalinguptaofficial@gmail.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> Signed-off-by: Nalin Gupta <nalinguptaofficial@gmail.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> Signed-off-by: Nalin Gupta <nalinguptaofficial@gmail.com>
There was a problem hiding this comment.
Actionable comments posted: 3
♻️ Duplicate comments (1)
holidays/countries/guinea.py (1)
72-75: 🧹 Nitpick (assertive)Add a brief historical/legal reference above this conditional.
A short comment explaining why “Second Republic Day” is limited to 1985–2021 would help future readers, as suggested in previous comments.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
holidays/countries/guinea.py(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
holidays/countries/guinea.py (5)
Learnt from: KJhellico
PR: vacanza/holidays#2398
File: holidays/countries/guinea.py:101-106
Timestamp: 2025-04-03T13:03:16.558Z
Learning: For Islamic holidays in Guinea like "Lendemain de la nuit Lailatoul Qadr" (Day after Night of Power) and "Lendemain de la nuit du Maoloud" (Day after Prophet's Birthday), the naming refers to the daylight hours following the night when these Islamic observances occur. Since in the Islamic calendar days begin at sunset rather than midnight, methods like `_add_laylat_al_qadr_day` and `_add_mawlid_day` correctly calculate these dates without requiring an additional day offset in the implementation, following the same pattern as in the Ivory Coast implementation.
Learnt from: KJhellico
PR: vacanza/holidays#2398
File: holidays/countries/guinea.py:101-106
Timestamp: 2025-04-03T13:03:16.558Z
Learning: For Islamic holidays in Guinea like "Lendemain de la nuit Lailatoul Qadr" (Day after Night of Power) and "Lendemain de la nuit du Maoloud" (Day after Prophet's Birthday), the naming refers to the daylight hours following the night when these Islamic observances occur. Since in the Islamic calendar days begin at sunset rather than midnight, methods like `_add_laylat_al_qadr_day` and `_add_mawlid_day` correctly calculate these dates without requiring an additional day offset in the implementation.
Learnt from: nalin-28
PR: vacanza/holidays#2398
File: holidays/countries/guinea.py:65-72
Timestamp: 2025-04-02T17:22:27.207Z
Learning: Guinea stopped recognizing "Second Republic Day" and "All Saint's Day" as public holidays from 2021 onwards.
Learnt from: PPsyrius
PR: vacanza/holidays#2398
File: holidays/countries/guinea.py:73-77
Timestamp: 2025-04-03T12:36:41.201Z
Learning: In the Holidays library, comments explaining year restrictions for holidays should be placed above the year check conditional statement, not inside it. Example format:
```python
# reason why goes here
if start_year <= self._year <= end_year:
# Holiday name
self._add_holiday_function(tr("Holiday Name"))
Learnt from: KJhellico
PR: #2388
File: holidays/countries/ivory_coast.py:98-107
Timestamp: 2025-04-02T17:22:27.207Z
Learning: In the Islamic calendar, days begin at sunset rather than midnight. For holidays like "Lendemain de la Nuit du Destin" (Day after Night of Destiny) in Ivory Coast, the name refers to the daylight hours following the night of Laylat al-Qadr (27th of Ramadan). The implementation uses _add_laylat_al_qadr_day which correctly calculates this as the 27th day of Ramadan in the Gregorian calendar.
</details>
</details><details>
<summary>🧬 Code Definitions (1)</summary>
<details>
<summary>holidays/countries/guinea.py (2)</summary><blockquote>
<details>
<summary>holidays/calendars/islamic.py (1)</summary>
* `_CustomIslamicHolidays` (3881-3882)
</details>
<details>
<summary>holidays/groups/islamic.py (6)</summary>
* `IslamicHolidays` (20-416)
* `_add_mawlid_day` (319-329)
* `_add_laylat_al_qadr_day` (298-307)
* `_add_eid_al_fitr_day` (152-163)
* `_add_eid_al_adha_day` (109-120)
* `_add_eid_al_adha_day_two` (122-130)
</details>
</blockquote></details>
</details>
</details>
<details>
<summary>🔇 Additional comments (1)</summary><blockquote>
<details>
<summary>holidays/countries/guinea.py (1)</summary>
`100-102`: **This implementation for Day after Prophet's Birthday is correctly aligned with local convention.**
The approach matches the Ivory Coast pattern where “day after” naming reflects the daylight hours following the night observance.
</details>
</blockquote></details>
</details>
<!-- This is an auto-generated comment by CodeRabbit for review status -->
|
Proposed change
Add Public Holidays for Guinea (Republic of Guinea)
Supported Languages:
en_US,frFixes #1194
Type of change
holidaysfunctionality in general)Checklist
make check, all checks and tests are green