Update subdivision names for Presidents' Day in the United States #2299
Conversation
There was a problem hiding this comment.
PR Overview
This PR updates the naming and observance of Washington's Birthday across various US subdivisions to reflect the official holiday names (e.g., Presidents' Day, Washington-Lincoln Day) used in different states. The key changes include:
- Updating the holiday name for Washington's Birthday in the main US holiday population logic condition with an explicit exclusion list.
- Adding state‑specific methods for subdivisions (AK, AZ, CA, CO, HI, etc.) with appropriate holiday name updates.
- Adjusting related tests to match the updated holiday names.
Changes
| File | Description |
|---|---|
| holidays/countries/united_states.py | Updates the logic and holiday name for Washington's Birthday for various subdivisions. |
| tests/countries/test_united_states.py | Expands and adapts the exclusion list and expected holiday names to align with the revisions. |
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (3)
holidays/countries/united_states.py:232
- Verify that the updated exclusion list for Washington's Birthday accurately reflects the official state-specific holiday guidelines. Any inconsistency may cause a mismatch in holiday observance between the default logic and the state-specific methods.
if self._year >= 1971 and self.subdiv not in { ... }:
holidays/countries/united_states.py:797
- [nitpick] The holiday name 'Presidents Day' for this subdivision is missing an apostrophe compared to other instances ('Presidents' Day'). Please confirm if this difference is intentional based on state guidelines.
self._add_holiday_3rd_mon_of_feb("Presidents Day")
tests/countries/test_united_states.py:362
- Ensure that the expanded exclusion list in the tests aligns correctly with the updated holiday population rules in the country module. The test list should reflect the same state exclusions and expected observance names as defined in the updated code.
subdiv_dont = { ... }
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2299 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 201 201
Lines 12291 12332 +41
Branches 1745 1768 +23
=========================================
+ Hits 12291 12332 +41 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
@parkerbxyz thanks for the hard work you've done to gather those pieces of standardization information!
It seems we need to address some duplicate holidays first (see AK, ID or MD snapshots)
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
There was a problem hiding this comment.
LGTM 👍
// @KJhellico and I made the requested changes in order to include this PR into today's release.
Proposed change
Many subdivisions in the United States use a different name for “Washington's Birthday” federal holiday. This pull request adds the official name used by each subdivision for this holiday.
Type of change
holidaysfunctionality in general)Checklist
make check, all checks and tests are green