Invoke OnUsageError when missing required flags #2161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of missing required flags, the OnUsageError function will now be invoked instead of directly returning the error.
Juneezee
approved these changes
Jun 24, 2025
|
Hi @Juneezee , can you help me with merging this? |
|
@dearchap There seem to be some problems with the CodeQL checks that are preventing the auto-merge. Could you take a quick look when you are available? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This PR aims to fix the issue noted in #2145
command_run.go-func (cmd *Command) runhas been modified to run theOnUsageErrorfunction when thecheckAllRequiredFlagscheck fails.Which issue(s) this PR fixes:
Fixed #2145