This repository was archived by the owner on Aug 14, 2019. It is now read-only.
adds explicit initialization and peek (namespace) handlers to lib/tapp #1186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtobin
reviewed
Jun 2, 2019
| app-state=state-type | ||
| == | ||
| +$ tapp-peek | ||
| [%noun ?(? (set contract))] |
There was a problem hiding this comment.
My mental parser paused for a second here to verify that ?(? wasn't some strange irregular syntax it hadn't seen before.
|
I don't have ny github password on my phone so I can't mark it approved
right now, but this looks good to me.
…On Sat, Jun 1, 2019, 14:35 Joe Bryan ***@***.***> wrote:
@joemfb <https://github.com/joemfb> requested your review on: #1186
<#1186> adds explicit initialization
and peek (namespace) handlers to lib/tapp.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#1186?email_source=notifications&email_token=ABKLYGFDOGT3FNSEFQGGH5LPYLFRBA5CNFSM4HSBE6PKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGORYDYSKI#event-2382858537>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABKLYGH525YCFSHHG6UPXR3PYLFRBANCNFSM4HSBE6PA>
.
|
jtobin
reviewed
Jun 2, 2019
| ++ handle-peer | ||
| |= * | ||
| ~| %default-tapp-no-sole | ||
| ?< ?=([%sole *] +<) |
There was a problem hiding this comment.
As an anti-larkite, I would give the sample a face and kill the lark here:
++ handle-peer
|= =noun
~| %default-tapp-no-sole
?< ?=([%sole *] noun)
(async-fail:async-lib %no-peer-handler >path< ~)
jtobin
approved these changes
Jun 2, 2019
|
🚢 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And a couple default namespace paths for inspecting the state of a tapp.