+
Skip to content
This repository was archived by the owner on Aug 14, 2019. It is now read-only.

Conversation

joemfb
Copy link
Contributor

@joemfb joemfb commented May 27, 2019

This PR uses $> (fixed in #1176) to deduplicate the +note (outgoing "request") and +sign (incoming "response") interfaces of all the vanes, defining these interfaces in terms of the +task (incoming "request") and +gift (outgoing "response") interfaces of other vanes wherever possible.

I've also moved all the +note/+sign definitions into the vanes themselves -- some were previously in %zuse, but there's no reason for anything but the vanes (and their tests) to reference these.

@joemfb joemfb force-pushed the dedupe-vane-interfaces branch from d6b5119 to f200138 Compare May 27, 2019 07:42
$>(%look task) :: set ethereum source
== ::
$: @tas ::
$% $>(%init vane-task) :: report install

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this formatting is inconsistent with the rest

{$this p/? q/clip:eyre r/httq:eyre} :: eyre: in request
{$thud ~} :: eyre: in cancel
{$wake ~} :: behn: wakeup
+$ unix-task :: input from unix

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be nice to define vane interfaces in terms of this, rather than the other way around. That way you could look at a vane interface and immediately see which moves come from Unix. Could be done in a different PR, though.

Copy link

@belisarius222 belisarius222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@philipcmonk philipcmonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovin' it

@jtobin jtobin merged commit d33f9ea into master May 28, 2019
@jtobin jtobin deleted the dedupe-vane-interfaces branch May 28, 2019 06:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载