-
Notifications
You must be signed in to change notification settings - Fork 58
fix higher-order mold parameter-bunts #1177
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I feel like there's a nugget of wisdom about universal quantification and our defaulting system here, but I can't articulate it.
One thing to note is that mold builders defined manually would not benefit from this change and must adjust the bunts of their own mold parameters. I'm not confident we even support manually constructed mold builders outside of +* anymore, though, so that might not matter.
I disagree with your unarticulated nugget! Or rather, I disagree with the implication of universality. In particular, it's easy to conflate It might be clearer and more accurate to define And it's worth noting that the different arm types should be represented in |
I would say that we don't have the capability to not support manually-defined mold-builders, although they should be frowned upon. Ironically enough, they already don't have this problem due to the definition of |
I think I agree with you overall, but your mold bunt doesn't nest in +mold.
I think you want $~ |=(* +<) $-(* *)
On Sat, May 25, 2019 at 10:51 AM Joe Bryan ***@***.***> wrote:
I would say that we don't have the capability to not support
manually-defined mold-builders, although they should be frowned upon.
Ironically enough, they already don't have this problem due to the
definition of +mold given above.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#1177?email_source=notifications&email_token=AAGVR5I2RCJE5R4EE77SWZLPXF4BHA5CNFSM4HPUB2OKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWHWHXI#issuecomment-495936477>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAGVR5NTCLENFZSQKPJSZGTPXF4BHANCNFSM4HPUB2OA>
.
--
—
~rovnys-ricfer
https://urbit.org
|
LGTM upon re-review |
I still don't get why it's |
It seems to me that The macro expansion does seem a little too cute, but that's an implementation detail of
|
Ah, okay, I see it. Relatedly, I found a nice hoon emoji:
|
This PR fixes higher-order molds (ie,
+*
specs) in cases where their parameters are bunted. It does so be explicitly defaulting the$-
to an identity function.Before:
After: