Tiebout - Apple Push Notification Server App #1084
Conversation
There was a problem hiding this comment.
Thanks for the touch-ups! Here's a few stragglers.
The /lib file still exists, that needs to be thrown out of version control.
Lastly, there's still old syntax and indentation oddities around. (?+s for the most part.) If you do one last style pass over this, you should be good. (:
app/tiebout.hoon
Outdated
| [~ this] | ||
| ?~ wir | ||
| (mean [leaf+"invalid wire for diff: {(spud wir)}"]~) | ||
| ?+ i.wir |
There was a problem hiding this comment.
I thought I left a comment about this in the initial review but can't find it, so maybe it got eaten? You already do a saner ?+ in the ++diff-hall-* cases, you'll want to apply that here and in ++quit too.
(Also indenting for this particular one is borked.)
app/tiebout.hoon
Outdated
| =/ not/notification :+ | ||
| token.sta | ||
| 'com.tlon.urbit-client' | ||
| pay |
There was a problem hiding this comment.
You're probably fine putting these between [] on one line. If you feel that's too long, proper :+ form would be
:+ token.sta
'com.tlon.urbit-client'
pay
sur/tiebout.hoon
Outdated
| @@ -0,0 +1,62 @@ | |||
| :: | |||
| :::: /lib/tiebout/hoon | |||
There was a problem hiding this comment.
Pretty sure filepaths in file headers is outdated style.
And as mentioned before, lots of the structures (cards, state) here really belong in the /app file instead, since they aren't shared to/used by other applications/libraries interfacing with Tiebout.
6d250e3 to
15e6949
Compare
15e6949 to
cf0b409
Compare
|
Hey man! I removed the lib from the repository, made the indentation change and removed the |
There was a problem hiding this comment.
This should be ready to go now.
There's still old syntax in there. (;
My comment about string interpolation in 'cords' (line 244) also remains unresolved.
These aren't show-stoppers per se, I guess. Assuming you tested this to actually work, yeah, this can go in.
Thanks for bearing with me. (^:
| :: | ||
| :: %our | ||
| :: | ||
| {%our @ @} |
There was a problem hiding this comment.
While these are technically correct and will successfully match /our/whatever aka [%our %whatever ~], it's better to describe a limited-length wire by actually ending with ~ in the type description.
* master: (38 commits) bumped ames protocol number landscape 3f83c798bd61b7e6cef5c4e2f7c7f3ac89d4ec09 removed hard calls on json blobs Support eth_getBlockByNumber Ethereum RPC call added initial image support to udon parser (#1085) Tiebout - Apple Push Notification Server App (#1084) Implement +from-unix for turning timestamps into @da Add support to `lens-command` for pill output and optimized base64 encoding. (#1068) Point to the correct topics when decoding Azimuth events Add trailing newlines Use unit to disambiguate poll timer state Lightly re-order ++watcher core, add comments Implement ++peek so the app can by scried Remove debug pokes Implement %eth-watcher, an app for tracking Ethereum events add control flow to |verb Be accurate in incoming/hoon-side structures also More accurately represent Ethereum RPC filter topics also pin validate-x to now pin to local time because using local desk ...
* App for sending Apple Push Notifications * First pass at Hall subscription logic * Tiebout app works end to end, can receive actions via Eyre, and can resubscribe to circles * style changes for tiebout
Simple gall app for sending push notifications to an urbit user's iPhone when they receive a Hall message from a circle that has been subscribed to these notifications.