DX-2161: fall back to returning the message string if message is not parsable #1391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able when the message was a string, we tried to parse which got an error. Also, test durations were too short and we were getting the subscribe event instead of the message event
alitariksahin
previously approved these changes
Oct 6, 2025
alitariksahin
approved these changes
Oct 6, 2025
renovate bot
added a commit
to JeromeFitz/websites
that referenced
this pull request
Oct 6, 2025
<!-- COMMIT_BODY_TEXT_BEGIN --> This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@upstash/redis](https://redirect.github.com/upstash/upstash-redis) | [`1.35.4` -> `1.35.5`](https://renovatebot.com/diffs/npm/@upstash%2fredis/1.35.4/1.35.5) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>upstash/upstash-redis (@​upstash/redis)</summary> ### [`v1.35.5`](https://redirect.github.com/upstash/redis-js/releases/tag/v1.35.5) [Compare Source](https://redirect.github.com/upstash/upstash-redis/compare/v1.35.4...v1.35.5) #### What's Changed - Update function fromEnv() summary to also include Vercels naming convention by [@​Ruitjes](https://redirect.github.com/Ruitjes) in [upstash/redis-js#1390](https://redirect.github.com/upstash/redis-js/pull/1390) - DX-2161: fall back to returning the message string if message is not parsable by [@​CahidArda](https://redirect.github.com/CahidArda) in [upstash/redis-js#1391](https://redirect.github.com/upstash/redis-js/pull/1391) #### New Contributors - [@​Ruitjes](https://redirect.github.com/Ruitjes) made their first contribution in [upstash/redis-js#1390](https://redirect.github.com/upstash/redis-js/pull/1390) **Full Changelog**: <upstash/redis-js@v1.35.4...v1.35.5> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- <!-- COMMIT_BODY_TEXT_END --> <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xMzEuOSIsInVwZGF0ZWRJblZlciI6IjQxLjEzMS45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyLwn5Om77iPIERlcGVuZGVuY2llcyJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
abhiaiyer91
pushed a commit
to mastra-ai/mastra
that referenced
this pull request
Oct 9, 2025
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@upstash/redis](https://redirect.github.com/upstash/upstash-redis) | dependencies | patch | [`^1.35.4` -> `^1.35.5`](https://renovatebot.com/diffs/npm/@upstash%2fredis/1.35.4/1.35.5) | --- ### Release Notes <details> <summary>upstash/upstash-redis (@​upstash/redis)</summary> ### [`v1.35.5`](https://redirect.github.com/upstash/redis-js/releases/tag/v1.35.5) [Compare Source](https://redirect.github.com/upstash/upstash-redis/compare/v1.35.4...v1.35.5) ##### What's Changed - Update function fromEnv() summary to also include Vercels naming convention by [@​Ruitjes](https://redirect.github.com/Ruitjes) in [upstash/redis-js#1390](https://redirect.github.com/upstash/redis-js/pull/1390) - DX-2161: fall back to returning the message string if message is not parsable by [@​CahidArda](https://redirect.github.com/CahidArda) in [upstash/redis-js#1391](https://redirect.github.com/upstash/redis-js/pull/1391) ##### New Contributors - [@​Ruitjes](https://redirect.github.com/Ruitjes) made their first contribution in [upstash/redis-js#1390](https://redirect.github.com/upstash/redis-js/pull/1390) **Full Changelog**: <upstash/redis-js@v1.35.4...v1.35.5> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNDMuMyIsInVwZGF0ZWRJblZlciI6IjQxLjE0My4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> --------- Co-authored-by: dane-ai-mastra[bot] <199668360+dane-ai-mastra[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when the message was a string, we tried to parse which got an error. Also, test durations were too short and we were getting the subscribe event instead of the message event