-
-
Notifications
You must be signed in to change notification settings - Fork 105
Add assignee field support to Gitea Pull Request Action to achieve parity with GitHub implementation #6084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Assignes now can be set when creating a Gitea PR, for the Reviewers field we still need a patch in the official go-sdk of gitea (https://gitea.com/gitea/go-sdk/pulls/730) |
@olblak please take a first look at the implementation. I currently want to keep this WIP while waiting for the SDK-PR |
Thanks for the quick PR. Regarding the table parameter, it's automatically generated by on the Jsonschema which is automatically generated based on the spec comments that you updated https://github.com/updatecli/updatecli/pull/6084/files#diff-2ce45b650dadceed4e695a15d9a3d384861b555efc9f7e4f0c44942b1b6873b7 |
Nice, I didn't have the time to test it yet but looking at the code it's already a nice improvement |
@olblak let's start with the "assignee" field to get this rewrite going! If the "reviewers" becomes available via the SDK i can open another PR. Please take a look at the code if possible :-) I also corrected the example in the Docs repository to work with the |
Once again, thanks for the pr, I just tested it works as expected. While you are at this, do you think it would make sense to allow configuring "labels", "milestone", and "deadline" => https://pkg.go.dev/code.gitea.io/sdk/gitea#CreatePullRequestOption Otherwise, I am happy to merge as it is and trigger a release |
@olblak thanks for merging and the quick/friendly responses! If i added the "reviewers" field, i will do the rest. Currently a bit packed with work |
This is still work in progress!!
Description:
Migrate Gitea Pull Request Action to official SDK and add reviewers field support
Fix #6081
This pull request enhances the Gitea Pull Request Action to support a assignees field, bringing feature parity with the GitHub Pull Request Action. The changes include:
Test
To test this pull request, you can use the following file with the "updatecli" repository pushed to an Gitea instance!
Build the binary and then run "updatecli apply --config CONFIG" with the above file.
Currently tested scenarios:
Additional Information
Tradeoff
The migration to the official SDK may introduce slight changes in behavior or error handling compared to the previous implementation. However, this is acceptable as it provides better long-term maintainability and access to the latest Gitea API features.
Potential improvement
Status: Work in Progress - Migration to official SDK completed, reviewers field implementation in progress