+
Skip to content

Conversation

SammyOina
Copy link
Contributor

@SammyOina SammyOina commented Aug 23, 2024

What type of PR is this?

This is a feature to simplify running manager using systemd

What does this do?

  • New Features

    • Introduced a new service management system for the Cocos application, enabling easy installation, running, and stopping of the Cocos Manager service.
    • Added configuration capabilities for managing operational parameters through the cocos-manager.env file.
  • Bug Fixes

    • Enhanced the cleaning process to ensure a clean build environment by updating the clean functionality.
  • Documentation

    • Added comments to clarify the purpose and configuration of the new service unit and environment settings.

Which issue(s) does this PR fix/relate to?

None

Have you included tests for your changes?

No

Did you document any new/modified feature?

No documentation will be added in another pr

Notes

make
sudo make install 
sudo make run
sudo systemctl status cocos-manager.service
journalctl -u cocos-manager.service

@SammyOina SammyOina self-assigned this Aug 23, 2024
Copy link
Contributor

@WashingtonKK WashingtonKK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are the different variables presented to manager?
i.e., how can I specify maximum memory or cpus?

Please also update docs in manager readme.

@dborovcanin
Copy link
Contributor

@SammyOina Please resolve conflicts.

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit bdfc5fd into ultravioletrs:main Aug 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载