Add menu-related components and stories for horizontal and vertical variants #1008
Conversation
Co-authored-by: pyrello <709009+pyrello@users.noreply.github.com>
|
@copilot We do not need a theme setting for the Vue menu component. |
Co-authored-by: pyrello <709009+pyrello@users.noreply.github.com>
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: pyrello <709009+pyrello@users.noreply.github.com>
Removed the theme prop from the Vue component in commit 3e46151. The
Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Co-authored-by: pyrello <709009+pyrello@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot We do not need Storybook story variants for menus with dark backgrounds. |
…ch updated form styles.
|
@copilot The showcase examples that were pulled in #1000 a couple steps ago contained classes and attributes that are specific to Drupal. They were copied from forms generated from Drupal. However this library should not contain these Drupal-isms. Please identify the Drupal-specific classes, IDs and attributes and remove them. |
Co-authored-by: pyrello <709009+pyrello@users.noreply.github.com>
Removed all Drupal-specific classes, IDs, and attributes in commit [short hash]: HTML/Template cleanup:
SCSS cleanup:
The showcase stories and supporting SCSS are now framework-agnostic. |
…tag and added presentation role.
…active, focus, hover) and nesting.
…h both icons and no icons. Commented out some recent updates.
…ame color at all nesting levels. Adjusted transitions for links to expand center out. Cleanup.
…et font-size for menus to avoid inconsistencies based on ul font-sizing.
Resolves #1002
Narrative
We would like to provide brand-approved guidance on menus should look in U of I websites and applications. Currently all of our menu styles originate from SiteNow and menus throughout that system have diverged in terms of styling and implementation. Menu related components in UIDS must be able to meet the needs of SiteNow, where they will eventually be implemented, as well as applications where the need for icons and drop-down menus diverge somewhat from how menus are represented on the web. As such, this PR seeks to create a starting point for representing menus that are consistent and meet all the requirements of the variety of applications they might be used for while still adhering to the relevant standards for accessibility.
Note: Drop-down and pop-out menus were not implemented in this slice and will be added in future slices.
How to test