fix null reference for unknown ELF ABIs #1358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
79dee7b to
a4b1c57
Compare
1b4a530 to
95cc0a9
Compare
`platform` was left uninitialized for unknown ELF ABIs Since `GetEnvironment` already returns `DefaultPlatform` for unknown environments, we can just call it
95cc0a9 to
0cd1555
Compare
|
Nice catch! Thanks for fixing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
platformwas left uninitialized for unknown ELF ABIs.Since
GetEnvironmentalready returnsDefaultPlatformfor unknown environments, we can just call it