uutils · cakebaker · Apr 18, 2024 · Apr 11, 2024 · Apr 12, 2024
diff --git a/src/find/matchers/mod.rs b/src/find/matchers/mod.rs
@@ -531,6 +531,14 @@ fn build_matcher_tree(
                 if !expecting_bracket {
                     return Err(From::from("you have too many ')'"));
                 }
+
+                let bracket = args[i - 1];
+                if bracket == "(" {
+                    return Err(From::from(
+                        "invalid expression; empty parentheses are not allowed.",
+                    ));
+                }
+
                 return Ok((i, top_level_matcher.build()));
             }
             "-d" | "-depth" => {
@@ -941,7 +949,10 @@ mod tests {
     fn build_top_level_matcher_too_many_brackets() {
         let mut config = Config::default();
 
-        if let Err(e) = build_top_level_matcher(&["-true", "(", ")", ")"], &mut config) {
+        if let Err(e) = build_top_level_matcher(
+            &["-type", "f", "(", "-name", "*.txt", ")", ")"],
+            &mut config,
+        ) {
             assert!(e.to_string().contains("too many ')'"));
         } else {
             panic!("parsing argument list with too many closing brackets should fail");
@@ -997,6 +1008,17 @@ mod tests {
         }
     }
 
+    #[test]
+    fn build_top_level_matcher_expression_empty_parentheses() {
+        let mut config = Config::default();
+
+        if let Err(e) = build_top_level_matcher(&["-true", "(", ")"], &mut config) {
+            assert!(e.to_string().contains("empty parentheses are not allowed"));
+        } else {
+            panic!("parsing argument list with empty parentheses in an expression should fail");
+        }
+    }
+
     #[test]
     fn comparable_value_matches() {
         assert!(

diff --git a/tests/find_cmd_tests.rs b/tests/find_cmd_tests.rs
@@ -505,3 +505,16 @@ fn find_accessible() {
         .stderr(predicate::str::is_empty())
         .stdout(predicate::str::contains("abbbc").not());
 }
+
+#[test]
+fn expression_empty_parentheses() {
+    Command::cargo_bin("find")
+        .expect("found binary")
+        .args(["-true", "(", ")"])
+        .assert()
+        .failure()
+        .stderr(predicate::str::contains(
+            "empty parentheses are not allowed",
+        ))
+        .stdout(predicate::str::is_empty());
+}