Print help/version without error prefix #455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #455 +/- ##
==========================================
+ Coverage 77.19% 77.29% +0.10%
==========================================
Files 36 36
Lines 4416 4436 +20
Branches 988 991 +3
==========================================
+ Hits 3409 3429 +20
Misses 1004 1004
Partials 3 3 ☔ View full report in Codecov by Sentry. |
|
please improve the commit explaining what you are fixing |
xargs, when executed with -h/--help or -V/--version, is printing an "Error: " prefix before the help and version text. The exit code is also incorrect (1, instead of 0). Display the help/version text without the erroneous prefix, and exit with the correct exit code (success, 0). Add tests for this bug to prevent regressions.
1aff400 to
a798e62
Compare
|
I updated the commit. New commit message: |
a798e62 to
fecba23
Compare
sylvestre
reviewed
Sep 23, 2024
tests/xargs_tests.rs
Outdated
| .args([option_style]) | ||
| .assert() | ||
| .success() | ||
| .code(0) |
There was a problem hiding this comment.
don't bother updating it but I think success implies code(0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.