fix(ptx): Remove extra space before truncation marker and add a related test #8784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n test (`test_truncation_no_extra_space_in_after`) has been added. Close#8783
|
GNU testsuite comparison: |
CodSpeed Performance ReportMerging #8784 will not alter performanceComparing Summary
Footnotes
|
…n test (`test_truncation_no_extra_space_in_after`) has been added. Close#8783
…ix/ptx-truncation-space
|
GNU testsuite comparison: |
|
Thanks for your PR! |
You're welcome! Happy to contribute! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a compatibility bug in
ptxwhere an extra leading space was added before the truncation marker in bothroff(-G) andtexformats. The output now matches GNUptx.Related Issue
Closes #8783
Changes Made
trim_idxfunction to correctly trim leading whitespace from the "after" context before truncation calculations.test_truncation_no_extra_space_in_afterto verify the fix and prevent future regressions.GNU
ptx(Correct Behavior)uutils/ptxBefore Fixuutils/ptxAfter FixHow to Test
The bug can be verified with the following test case. After this fix, the output of
uutils/ptxis identical to GNUptx.