+
Skip to content

sort: implement locale aware sort + document the impact on the performances #8752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

sort: implement locale aware sort + document the impact on the performances #8752

wants to merge 3 commits into from

Conversation

sylvestre
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 27, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #8752 will degrade performances by 33.37%

Comparing sylvestre:sort-perf (48257d7) with main (32eef06)

Summary

❌ 10 regressions
✅ 83 untouched
⏩ 1 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ sort_case_insensitive[100000] 64.3 ms 90.6 ms -29.01%
❌ sort_case_insensitive[500000] 328.1 ms 452.4 ms -27.49%
❌ sort_dictionary_order[100000] 143.6 ms 211.3 ms -32.04%
❌ sort_dictionary_order[500000] 732.2 ms 1,064.1 ms -31.19%
❌ sort_numeric[100000] 192.7 ms 289.3 ms -33.37%
❌ sort_numeric[500000] 921.1 ms 1,363.2 ms -32.43%
❌ sort_reverse_locale[100000] 158.6 ms 235.3 ms -32.57%
❌ sort_reverse_locale[500000] 820.9 ms 1,198.7 ms -31.52%
❌ sort_unique_locale[100000] 158.2 ms 234.8 ms -32.62%
❌ sort_unique_locale[500000] 810.7 ms 1,188.8 ms -31.81%

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/sort/sort-rand. tests/sort/sort-rand is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sylvestre
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载