basename: Handle non-unicode parameters #8375
Merged
+44
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to handle non-Unicode strings correctly. The logic needs to be updated, next.
The test was not really testing for the right thing. If a non-unicode string is passed, the basename should be printed as-is.
|
GNU testsuite comparison: |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_basename: Fix test_invalid_utf8_args
The test was not really testing for the right thing. If a non-unicode
string is passed, the basename should be printed as-is.
basename: Fix basename function, print raw byte slice.
basename: Take in parameters as OSString
This will allow us to handle non-Unicode strings correctly.
The logic needs to be updated, next.