cat: add error handling in write_fast function #8091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
|
Thanks! |
sylvestre
pushed a commit
to sylvestre/coreutils
that referenced
this pull request
Jun 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8068.
The
write_fastfunction was silently ignoring read errors due to usingwhile let Ok(n) = handle.reader.read(&mut buf)pattern. Whenread()returned anErr, the loop would simply exit without propagating the error, potentially leading to incomplete output without any indication of failure.This PR replaces the while-let pattern with proper match-based error handling that immediately returns read errors using
Err(e) => return Err(e.into()).