ls: update chrono crate version and switch to new_lenient use
#7858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
drinkcat
reviewed
Apr 29, 2025
src/uu/ls/src/ls.rs
Outdated
| // TODO (#7802): Replace with new_lenient | ||
| StrftimeItems::new(custom_tz_fmt::custom_time_format(fmt).as_str()).parse_to_owned() | ||
| // Box the fmt value to make it static. | ||
| StrftimeItems::new_lenient(Box::leak( |
There was a problem hiding this comment.
Why the Box::leak change?
There was a problem hiding this comment.
Oh, my bad. Was too concentrated on parse(), missed that it can be done much simpler
|
I think this looks ok. @Qelxiros FYI. |
|
GNU testsuite comparison: |
|
Thanks! |
nickorlow
pushed a commit
to nickorlow/coreutils
that referenced
this pull request
Jul 17, 2025
…ls#7858) * update chrono crate version and switch to new_lenient use * bring back custom_tz_fmt and update test * update chrono version in fuzz lock file * replace boxing with parse_to_owned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrono just released a new version of their crate, introducing more flexible way to parse unknown format specifiers.
Closes #7802