fmt: accept repeated arguments #6355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e5c080e to
2097062
Compare
|
Changes since last push: Forgot to commit the test data, whoops :D |
cakebaker
reviewed
May 5, 2024
cakebaker
reviewed
May 5, 2024
2097062 to
3277bcb
Compare
|
Changes since last push:
|
3277bcb to
a13949b
Compare
|
Changes since last push:
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out, just a simple
args_override_self(true)is precisely the correct behavior.This is also correct with regard to
-p,-w,-g; I checked (and found #6352, #6353, #6354 in the process of doing so).This is work towards #5998.
Note that even though I added some basic tests, a huge chunk of the functionality is still untested, especially
-c,-x/-X,-t,-m,-q,-T, and of course-g, which is broken (known issue).