du: give -h output the same precision as GNU coreutils
#6226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
This commit extract the `display_size()` helper from `ls` into `uucore` as `human_readable` to be similar to the gnulib helper so that the human readable display of sizes can be shared between ls, du, df.
When printing the `du -h` output GNU coreutils does autoscale the size, e.g. ``` $ truncate -s12M a $ truncate -s8500 b $ truncate -s133456345 c $ truncate -s56990456345 d $ du -h --apparent-size a b c d 12M a 8,4K b 128M c 54G d ``` Align our version to do the same by sharing the code with `ls`. Closes: uutils#6159
98a0403 to
89af8b9
Compare
|
Good work, thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When printing the
du -houtput GNU coreutils does autoscalethe size, e.g.
Align our version to do the same by sharing the code with
ls.Closes: #6159
ls,uucore: extract display
human_readable()helper from lsThis commit extract the
display_size()helper fromlsintouucoreashuman_readableto be similar to the gnulib helperso that the human readable display of sizes can be shared between
ls, du, df.