+
Skip to content

cat: fix #5186 by adding explicit flush. #5256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 6, 2024
Merged

cat: fix #5186 by adding explicit flush. #5256

merged 8 commits into from
Oct 6, 2024

Conversation

gim913
Copy link
Contributor

@gim913 gim913 commented Sep 6, 2023 •
edited by sylvestre
Loading

#5186
See linked issue for details

@cakebaker cakebaker changed the title Fix #5186 by adding explicit flush. cat: fix #5186 by adding explicit flush. Sep 7, 2023
@cakebaker cakebaker linked an issue Sep 7, 2023 that may be closed by this pull request
cat: wrong concatenation binary content #5186
Closed
@gim913 gim913 force-pushed the missing-stdout-flush branch from 81ec096 to a224846 Compare September 7, 2023 09:04
sylvestre
sylvestre reviewed Oct 10, 2023
View reviewed changes
sylvestre
sylvestre reviewed Oct 10, 2023
View reviewed changes
@sylvestre
Copy link
Contributor

@gim913 ping ?

@sylvestre sylvestre force-pushed the missing-stdout-flush branch from a224846 to ca688cf Compare December 25, 2023 12:02
@gim913
Copy link
Contributor Author

gim913 commented Dec 27, 2023

@sylvestre hi, sorry, missed previous message, will try to address this this or next week, thanks 👋

@sylvestre
Copy link
Contributor

@gim913 ping ? :)

@gim913
Copy link
Contributor Author

gim913 commented May 21, 2024

Hi, sorry, life happened, and then rust update forced me to fight with llvm installation 😢
Can't test that spellcheck change, based it on other uses inside the file, hope it's ok.

P.S. want me to rebase and/or squash the branch?

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/timeout/timeout is no longer failing!

@gim913
Copy link
Contributor Author

gim913 commented Jun 28, 2024

@sylvestre ping? ;)

P.S. want me to rebase and/or squash the branch?

BenWiederhake
BenWiederhake reviewed Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@BenWiederhake BenWiederhake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff looks good to me, and could be merged.

Please rebase on top of current main; there are many CI failures, and since this branch is roundabout 150 commits behind it, I'd like to see a (more) successful run first.

@gim913 gim913 force-pushed the missing-stdout-flush branch from 690b850 to 416ecc6 Compare July 3, 2024 14:53
@gim913
Copy link
Contributor Author

gim913 commented Jul 4, 2024

Hello, are the two failures visible above something known?
I've tried looking at produced android artifacts (screenshots), but they're not super helpful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

@cakebaker
Copy link
Contributor

Yes, the Android tests currently also fail for other PRs and hence are unrelated to this PR. Some of the other failing tests, however, are related to your PR :|

@cakebaker cakebaker force-pushed the missing-stdout-flush branch from 416ecc6 to 7ff138a Compare October 3, 2024 07:46
BenWiederhake
BenWiederhake approved these changes Oct 6, 2024
View reviewed changes
Copy link
Collaborator

@BenWiederhake BenWiederhake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, remaining CI failures are a known issue (fixed by #6762).

@BenWiederhake BenWiederhake merged commit d8eb4e2 into uutils:main Oct 6, 2024
66 of 68 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Nov 16, 2024
Merged
@moonfruit moonfruit mentioned this pull request Nov 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sylvestre sylvestre sylvestre left review comments

@BenWiederhake BenWiederhake BenWiederhake approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cat: wrong concatenation binary content

4 participants

@gim913 @sylvestre @cakebaker @BenWiederhake
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载