Add support for large messages #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix implicit type conversion in reader that caused byte overflow when number of fields in definition message in >85. - Add real life fit activity to the test quite to replicate the problem - Fix definition message creation logic in `writer` -- now it scans all records of specific type to find all fields that have valid values to build a definition message. Fixes #43 and #53
|
@bpg Thanks for digging into this. I'll try to take a look as soon as possible. |
|
Sorry for the delay... Thanks for spotting the overflow. Suggestion, could we just remove the |
|
Thanks, updated! |
This was referenced Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
writer-- now it scans all records of specific type to find all fields that have valid values to build a definition message.This fixes #43, and fixes #53